Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const overload for tbb::combinable combine_each #1189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zak-K-Abdi
Copy link

Description

Add a const overload for combine_each in combinable.h and enumerable_thread_specific.h as the ets object would also need a const overload. This is my first pull request to oneTBB and decided to work on issue #957 as it is a small change.

Fixes #957

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@pavelkumbrasev
Copy link
Contributor

Hi @Zak-K-Abdi, Could you please update test for ETS and add test that won't compile without this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] tbb::combinable combine_each should offer a const overload.
2 participants