GitHub: slack notification for RFCs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpirogov
reviewed
May 9, 2024
|
@mkrainiuk @toxicscum: Can someone review it? |
mkrainiuk
approved these changes
May 13, 2024
dnhsieh-intel
approved these changes
May 14, 2024
|
Thanks for merging. The last step is to add the slack token as a secret for the repo. I sent it to @toxicscum in teams. |
This was referenced May 14, 2024
|
@toxicscum Kindly help let us know, once the slack token is added as a secret for the repo.Thanks! |
|
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish a notification to the onemkl channel in the UXL slack space when a PR is labeled RFC. To see a sample, look at rc-test channel. They are some test messages for onednn for the same workflow. This is the same workflow as oneapi-src/oneDNN#1900. Only the channel name has changed.
To enable the notification, someone with admin privileges must add a secret called SLACK_BOT_TOKEN to the repo. I can provide the value of the token in a DM. After the secret is added and this PR is merged, then new PR's with the RFC label will trigger the notification.
Addresses part of https://github.com/orgs/uxlfoundation/projects/5?pane=issue&itemId=56606833