[RNG] Fixed some bugs for device API #470
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It doesn't make sense to keep constructors with
std::initializer_list
formcg31m1
andmcg59
random generators since one seed value is enough. Size of the state formcg31m1
is 31 bits,uint32_t
is enough to store the initial state. Formcg59
size is 59 bits,uint64_t
is enough. So, let's keep onlystd::uint32_t seed
formcg31m1
andstd::uint64_t seed
formcg59
.PR for the Spec is here: uxlfoundation/oneAPI-spec#525.
Checklist
See [oneMKL][RNG] Fixed some bugs for oneMKL RNG device API uxlfoundation/oneAPI-spec#525