Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNG] Fixed some bugs for device API #470

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andreyfe1
Copy link
Contributor

Description

It doesn't make sense to keep constructors with std::initializer_list for mcg31m1 and mcg59 random generators since one seed value is enough. Size of the state for mcg31m1 is 31 bits, uint32_t is enough to store the initial state. For mcg59 size is 59 bits, uint64_t is enough. So, let's keep only std::uint32_t seed for mcg31m1 and std::uint64_t seed for mcg59.

PR for the Spec is here: uxlfoundation/oneAPI-spec#525.

Checklist

@andreyfe1 andreyfe1 requested a review from iMartyan April 9, 2024 14:41
Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants