Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit #243

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Commit #243

wants to merge 22 commits into from

Conversation

anantsrivastava30
Copy link
Contributor

Description

CPU Commit (run+compile time) + some restructuring of device specific headers

Fixes # (GitHub issue)

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

New interfaces

  • Have you provided motivation for adding a new feature as part of RFC and
    it was accepted? # (RFC)
  • What version of oneAPI spec the interface is targeted?
  • Complete New features checklist

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

Bug fixes

  • Have you added relevant regression tests?
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

t4c1 and others added 22 commits September 27, 2022 08:28
@t4c1
added dft interface and implementation stubs for mklgpu backend
6dbd3d4
@t4c1
format
32ddffe
@t4c1
addressed comments from internal review
e481041
@anantsrivastava30
Merge branch 'dft_interface' of https://github.com/t4c1/oneMKL into s…
bccc24c 
…ync_fft_interfaces
@anantsrivastava30
pimpl descriptor class skeleton
a48b583
@anantsrivastava30
push descriptor outside of device specific impl + desc class w/ prec …
47af09e 
…and dom
@anantsrivastava30
initial implementation of set_value and corresponding desc_impl class…
0c62927 
… changes
@anantsrivastava30
before refactoring the desc_impl class
d5f824b
@anantsrivastava30
refactor and move desc class outside of pimpl & constructor generaliz…
710a4e1 
…ation
@anantsrivastava30
enable setting strides
3f9d0b8
@anantsrivastava30
cpu commit+set_value
ba84e0e
@anantsrivastava30
address reviews
90dba9e
@anantsrivastava30
adress commit handle and error handling
1852b13
@anantsrivastava30
remove the use of error enums
c4ad8d8
@anantsrivastava30
generalize descriptor passing+extra forward decl
6cf88ba
@anantsrivastava30
revert testing
6de0cdd
@anantsrivastava30
fix linking issues; update backend table
9385c86
@anantsrivastava30
revert some old comments
96ac5de
@anantsrivastava30
further comments
04ed345
@anantsrivastava30
refactor descriptor source
820118e
@anantsrivastava30
efficient resource handle
9ed1f64
@anantsrivastava30
create_commit explicit instance
aa22374
@hjabird hjabird mentioned this pull request Dec 29, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anantsrivastava30 @t4c1