Migrate make to ICX/ICPX for Windows #2712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandr-Solovev
changed the title
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
ethanglaser
reviewed
Apr 26, 2024
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/azp run CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/intelci: run |
|
Any idea on windows examples internal CI fails? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we are migrating the project's default build system on Windows from the ICL to using ICX.
All changes are necessary to build oneDAL properly.
DAAL_EXPORTwas removed from some classes, due to correct dllexport build. In general just called functions should be marked as DAAL_EXPORT, and derived classes shouldn't. Most of the changes were done to have green CI.The concatenate operation
##works pretty strange and MKL function macros have been updated for it.[[maybe_unused]]is necessary for avoid compiler issues.The base version of C++ has been increased to C++17.