FPGA: Remove DataBundle from convolution2d code sample, update gasket IP #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up output messages from stream adapters - Readme updates recommended by Jessica
…nvert-to-std-array
whitepau
changed the title
|
Not sure why I was added to this review? @whitepau is there something here you'd like me to take a look at for some reason? |
yuguen-intel
changed the title
I'd like you to review the changes I made to the gasket IP in |
yuguen-intel
approved these changes
May 2, 2024
mdbtucker
reviewed
May 2, 2024
There was a problem hiding this comment.
Reviewed the .sv modules. These are very simple modules (they are just wires, there is no actual logic implemented at all), but you have not described what they do, either with their names or with comments. Just need to add some better descriptions.
Also, given how simple the modules are, I don't think the testbenches will be of use to users.
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...n2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avalon_to_axi_gasket.sv
Outdated
Show resolved
Hide resolved
...onvolution2d/quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/test_avalon_to_axi.sv
Outdated
Show resolved
Hide resolved
mdbtucker
reviewed
May 8, 2024
.../quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_avs_to_axs_pixel_gasket.sv
Outdated
Show resolved
Hide resolved
.../quartus_project_files/non_acds_ip/oneAPI_streaming_gasket/oneapi_axs_to_avs_pixel_gasket.sv
Outdated
Show resolved
Hide resolved
|
addressed mike's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Simplify convolution2d code sample by removing the proprietary DataBundle header and replace it with std::array for simplicity and portability.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration