FPGA: Fix namespace of deivce_ptr and host_ptr #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device_ptr and host_ptr aliases in DPC++ is from the [sycl_ext_intel_usm_address_spaces](sycl/doc/extensions/supported/sycl_ext_intel_usm_address_spaces.asciidoc) and as such is under the sycl::ext::intel namespace, rather than the sycl namespace. This commit fixes the namespaces of all uses of these aliases. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
9 tasks
yuguen-intel
changed the title
|
What version of the compiler are you using to test this? |
|
This is to adjust for upcoming releases, including current https://github.com/intel/llvm. Note that |
|
Ok - thanks I'll keep your PR opened for now until the FPGA compiler integrates this upstream change - I'll merge your PR then |
|
Some have been addressed (but not all) I'm still keeping this PR opened as I don't have a way to test it now, and we are close to the 2024.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
The device_ptr and host_ptr aliases in DPC++ is from the sycl_ext_intel_usm_address_spaces and as such is under the sycl::ext::intel namespace, rather than the sycl namespace. This commit fixes the namespaces of all uses of these aliases.
Replaces #2288.
External Dependencies
None.
Type of change
How Has This Been Tested?
Following the build instructions in each of the respective sample directories.