Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective enhancements #98

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Collective enhancements #98

wants to merge 56 commits into from

Conversation

suntong
Copy link

@suntong suntong commented Aug 2, 2021

Collective enhancements from different sources.

- transformed WriteDot() to (*dotGraph).WriteDot()
- transformed render() to (*analysis).Render()
- added variable opts *renderOpts to type analysis
- transformed analysisSetup() to (*analysis).OptsSetup()
- transformed processListArgs to (*analysis).ProcessListARgs()
- added (*analysis).OverrideByHTTP() with respective code part from
  handler.go
- transformed doAnalysis() to  (*analysis).DoAnalysis()

also did some code cleanup and added comments
position of function call in "posCallee" was derived from caller instead
of the callee
manipulated dot edge tooltip to display, where a function was called
moved appending of edges from edgeMap right before dotGraph is created
reason: edges tooltips need be changed for edge duplicates
tooltip of nodes representing functions is now set explicitly
nodes repressenting functions are now enhanced with the tooltips of the
outgoing edges
gentzeng and others added 26 commits October 6, 2020 16:37
- transformed WriteDot() to (*dotGraph).WriteDot()
- transformed render() to (*analysis).Render()
- added variable opts *renderOpts to type analysis
- transformed analysisSetup() to (*analysis).OptsSetup()
- transformed processListArgs to (*analysis).ProcessListARgs()
- added (*analysis).OverrideByHTTP() with respective code part from
  handler.go
- transformed doAnalysis() to  (*analysis).DoAnalysis()

also did some code cleanup and added comments
position of function call in "posCallee" was derived from caller instead
of the callee
manipulated dot edge tooltip to display, where a function was called
moved appending of edges from edgeMap right before dotGraph is created
reason: edges tooltips need be changed for edge duplicates
tooltip of nodes representing functions is now set explicitly
nodes repressenting functions are now enhanced with the tooltips of the
outgoing edges
Add rankdir command line flag for graph layout direction.
*Total -- 4,076.42kb -> 3,593.70kb (11.84%)

/images/main.png -- 89.59kb -> 71.28kb (20.44%)
/images/syncthing.png -- 226.21kb -> 180.46kb (20.22%)
/images/syncthing_group.png -- 334.79kb -> 270.74kb (19.13%)
/images/syncthing_ignore.png -- 230.31kb -> 188.70kb (18.07%)
/images/docker.png -- 589.83kb -> 488.12kb (17.24%)
/images/syncthing_focus.png -- 308.67kb -> 259.19kb (16.03%)
/images/travis.jpg -- 2,283.13kb -> 2,122.01kb (7.06%)
/images/gopher.png -- 13.90kb -> 13.20kb (5.04%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants