Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage.rst #1176

Merged
merged 3 commits into from
May 30, 2024
Merged

Update usage.rst #1176

merged 3 commits into from
May 30, 2024

Conversation

caxon
Copy link
Contributor

@caxon caxon commented May 14, 2024

Update phrasing about list merges on Usage documentation page.

Motivation

See issue #1175 . This updates a confusing line about list merges which may have been overlooked when changing the list merge behavior.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Open docs and verify that https://omegaconf.readthedocs.io/en/latest/usage.html#omegaconf-merge has updated the line about "Note how the port changes to 82"

Fixes

Fixes #1175

Related PRs

N/A

caxon added 2 commits May 14, 2024 11:44
update phrasing about list merges
@caxon caxon marked this pull request as ready for review May 14, 2024 15:51
@Jasha10 Jasha10 merged commit 6f9656b into omry:master May 30, 2024
1 of 5 checks passed
@Jasha10
Copy link
Collaborator

Jasha10 commented May 30, 2024

Thank you @caxon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading statement in "Usage" docs
2 participants