Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache me api response in redis #3746

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

cache me api response in redis #3746

wants to merge 3 commits into from

Conversation

sywhb
Copy link
Contributor

@sywhb sywhb commented Mar 28, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:08pm
omnivore-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:08pm

@jacksonh
Copy link
Contributor

I think we also might need to invalidate the cache when the user features change

@sywhb
Copy link
Contributor Author

sywhb commented Mar 28, 2024

I think we also might need to invalidate the cache when the user features change

Yeah that is a good one

@sywhb
Copy link
Contributor Author

sywhb commented Mar 28, 2024

I think we also might need to invalidate the cache when the user features change

Actually features are not cached because they are not queried from the function_resolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satindar satindar Awaiting requested review from satindar satindar is a code owner

@jacksonh jacksonh Awaiting requested review from jacksonh jacksonh is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sywhb @jacksonh