add browser extension feature to subscribe to feed #3305
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaachen is attempting to deploy a commit to the omnivore Team on Vercel. A member of the Team first needs to authorize it. |
aaachen
changed the title
jacksonh
reviewed
Jan 3, 2024
| function isFeedPage() { | ||
| const fileExtension = window.location.pathname.slice(-4).toLowerCase() | ||
| const hasXMLExtension = fileExtension === '.xml' | ||
| const xmlContentTypes = [ |
There was a problem hiding this comment.
I think we have a few other types we handle here /cc @sywhb
There was a problem hiding this comment.
yeah, i think .rss and .html could belong to here too
There was a problem hiding this comment.
ah the problem with HTML though is then it wont work for nomal pages, so maybe we have to just be conservative and handle XML here, even though a lot of sites return it as HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3059
Since XML pages are not html, the toolbox/notification cannot be shown (same issue with PDF even though in code it tries to display toolbox). UI to add notification can be iterated later, currently just logs in console.