Concurrency utilities

[pizzi80]

No description provided.

[BalusC]

Please check javadoc of Utils class:

omnifaces/src/main/java/org/omnifaces/util/Utils.java

Line 102 in 51e243b

* This class is indeed intended for internal usage only. We won't add methods here on user request. We only add methods

[pizzi80]

Yes but it's needed for future PR(s) of things that I would like to backport from my forked version

You asked for smaller PR(s), so I've splitted things, but It's time consuming and this was the easiest to backport ...

[BalusC]

The idea is if you need to reuse exactly the same private static method from a different class, then it's OK to move it into Utils class. Right now it's used in only one class, the very one where it's being declared.

[BalusC]

By the way, take a look at https://github.com/omnifaces/omniutils

A long time ago I've played with the idea to simply split/refactor all of OmniFaces "internal" util classes over there and adjust the OmniFaces build to shadow specific OmniUtils classes so we still end up with a single final JAR, but I couldn't get the build right. Perhaps it's time to take a second look.

cc: @arjantijms

[pizzi80]

This is also a very big problem in Jakarta EE "modules"

looking at the code of some modules I saw a lot of copy pasted methods
and Utils class ....

OmniUtils could teorically be a Jakarta Utils standard module

[pizzi80]

The idea is if you need to reuse exactly the same private static method from a different class, then it's OK to move it into Utils class. Right now it's used in only one class, the very one where it's being declared.

After some months or years, or if another commiter will need those method,
no one will remember that inside a class there is exaclty that utility method

Also no one will take care to make a proper refactor because:

1. it will increase the number of classes modified with a single PR
2. fear of bugs
3. fear of git conflict with other PRs

my 2 cents ;)