Modified yaml_fwrite to preserve file insertion order #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder of files in .core
|
Thanks for your contribution! Can you add a test to show the problem you're fixing, and to ensure that it actually stays fixed? And please add a version constraint on pyyaml if you depend on a feature that's only available from a certain version on (https://github.com/olofk/fusesoc/blob/main/setup.py#L56). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
sort_keys=Falsetoyaml.dumpcall inyaml_fwriteto preserve the order of insertion of the files to be written in the .core when writing a generator (for instance for packages to be included and compiled before other sources). Supported from PyYAML >= 5.1.