Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_libraries_directories on Windows fails due to mkdir -p #403

Open
pintert3 opened this issue Oct 24, 2023 · 3 comments
Open

make_libraries_directories on Windows fails due to mkdir -p #403

pintert3 opened this issue Oct 24, 2023 · 3 comments

Comments

@pintert3
Copy link

For windows CMD and Powershell, the -p is not necessary for the mkdir command, and is unrecognized. A work around I'd suggest is to check if the OS is Windows, and remove the -p in edalize/ghdl.py

@pintert3
Copy link
Author

I got a temporary fix for windows users, which I've discussed in TerosTechnology/vscode-terosHDL#472 (comment)

Will need to just do an OS check to offer an alternative command.

@olofk
Copy link
Owner

olofk commented Jan 25, 2024

Wrote a response in TerosTechnology/vscode-terosHDL#472 but forgot to write here. Do we need -p at all?

@pintert3
Copy link
Author

I must have missed the notification in the other issue. I haven't really over scrutinized the exact intention of the operation in the code, but from the looks of things, we're simply making library directories based on the names of the libraries. According to my knowledge, the -p would only be useful if we were likely to overwrite an existing directory. I don't know if we plan on using the same folders every time a run is triggered(haven't scrutinized enough), but if so, then it might be necessary. Otherwise, we don't need it at all cause every library seems to have it's own folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants