Fixing outlineView.py to enable the outline to show full Title

[BlackXanthus]

…the name of Character is too long

If the name of a character in POV is a long one, it reduces the amount of space for Title.

This modification (a simple change to the view) ensures that all columns fit it's content. This does enable a scroll-bar at the bottom of the screen for times when the full outline information is too long (QT default behaviour)

[BlackXanthus]

hmm.... It seems that the build on Semaphore fails because Semaphore doesn't have Qt installed, am I reading that correctly?

[gedakc]

Thanks @BlackXanthus for contributing to Manuskript.

The Semaphore Continuous Integration tests are only modifiable by the project owner. As such any changes to these would require action by @olivierkes. In the meantime please ignore issues reported by Semaphore CI.

As a general rule it is best to try to match the coding style used by the project.

Before I review this PR, would you please perform some cleanup on it?

1. Remove unnecessary whitespace changes. For example do not remove the space between self, and parent:
   QTreeView.__init__(self, parent)

2. Remove comments referencing old code line(s) and new code line(s).
   The differences are readily available from the git repository using commands like git diff and gitk --all.
   See your initially proposed commit Fixing outlineView.py to enable the outline to show full Title.

3. Remove mention of filename outlineView.py from the commit title.
   The file name is readily available from the git repository. In the title describe what the commit does in less than 80 characters. Extra explanation can be placed in the body of the commit message.

[BlackXanthus]

Due to holiday and work, I'll get to this asap.

[BlackXanthus]

Okay, I think I've caught all the changes that were asked for.

Hopefully I've managed to update it properly.

Thanks,

~BX

[gedakc]

Please squash all of these commits into one. This will make is easier to both review the code and to troubleshoot problems in the future. You will likely need to use the "-f" option when you push the updates to git.

[gedakc]

Again, please squash all of these commits into one.

[BlackXanthus]

Okay, somehow, my small commit has got wrapped up with someone making a spelling change!

[gedakc]

Thanks for trying again. Unfortunately I still see three commits, one of which is the "Fix typo". It would be advisable to rebase against the current develop branch to clean up this issue.

Additionally I still see unnecessary whitespace changes. For example in this change three extra blank lines are added, and a space is removed from QTreeView.__init__(self, parent):

---------------------- manuskript/ui/views/outlineView.py ----------------------
index 95cc786..3479485 100644
@@ -11,8 +11,11 @@ from manuskript.ui.views.outlineDelegates import outlineTitleDelegate, outlineCh
 
 
 class outlineView(QTreeView, dndView, outlineBasics):
+
+	
+
     def __init__(self, parent=None, modelCharacters=None, modelLabels=None, modelStatus=None):
-        QTreeView.__init__(self, parent)
+        QTreeView.__init__(self,parent)
         dndView.__init__(self)
         outlineBasics.__init__(self, parent)

Perhaps it would be simpler to start with a new branch based off the current olivierkes develop branch and only apply the minimum changes (no whitespace changes).

[worstje]

@gedakc I helped him out to fix this PR up for inclusion in 0.10.0; it is ready for merging now. 👍

[gedakc]

@worstje how were you able to push changes to the BlackXanthus repo for this PR?

If you could outline the steps, or point me to documentation on how you accomplished this then that would help me in the future.

Thanks,
Curtis

[worstje]

@gedakc BlackXanthus and I are on a Discord server together, so I asked him to invite me to be a collaborator for his repository.

I think you would have had direct access as a maintainer assuming BlackXanthus had checked the box on the PR that lets maintainers push changes to it, but I am not sure about that one as my experience with PRs is almost non-existant on the receiving end. 😄

[gedakc]

Thanks for the link.

I'm testing this change and discovered that issues can arise if the chapter or scene name is really long.

Manuskript with this PR applied:
(Note only one column shown and a portion at that - much scrolling required)

Manuskript without this PR applied:
(Note that "stretch value" makes more columns visible)

I know there are also reverse issues if other columns have really long names because these force a "stretch" column to be very small in width.

Perhaps a better compromise can be found?

[worstje]

I didn't test this PR; I only cleaned it up. I assumed all the usability testing and such had been covered already.

Personally I prefer the old behaviour, but that is mostly because I have some very long scene names and a big enough screen to get the gist to begin with.

Maybe we'd need a toggle so users can easily switch between whatever mode they prefer?

[gedakc]

I also prefer the old behaviour as well.

Currently users can work around the issue by enabling or disabling columns in the Outline view by using Edit -> Settings ->Views -> Outline.

If a minimum size could be set on the Title column then that might satisfy both situations. However from looking at the QHeaderView Class it appears that the minimumSectionSize applies to all columns. At least that is my interpretation.

EDIT: 'Sorry I missed answering your question.

Maybe we'd need a toggle so users can easily switch between whatever mode they prefer?

Ideally I'd like to follow the K.I.S.S philosophy and not add another control.

[TheJackiMonster]

As far as I understand this PR, the problem is that either title or POV can take too much space cutting off each other because they both can have pretty long names assigned (they are fully customizable).

I would suggest that the view containing the full table gets a horizontal scroll bar and columns get resizable because this problem can't really be solved automatically. Any author could have different priorities to see title or POV fully.

We can also make it configurable to use automatic fitting sizes for the columns (pretty much the current state) for all users who don't need that customization.

For all users with small screens who still don't want to scroll too much, we can add an overlay on hovering over the names.