Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settable color palettes #1096

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

TEParsons
Copy link

Allows users to specify what colour palette they want the app to show in. For now, I've added a dark and light palette but I tried to make it as easy as possible for other contributors to add colour schemes.

I couldn't get my head around the Settings UI and wasn't sure how best to implement it even if I could, so I've set it to default to light and left the settings option for more experienced contributors to figure out. So long as there's a setting called applicationPalette, its value should be used in much the same way as style to set the palette, and I've tested it by manually switching between themes.light and themes.dark and the palette works!

Light palette:
image

Dark palette:
image

@TheJackiMonster
Copy link
Collaborator

I've added a switch to the settings dialog now. It's still not fully functional. For example the theme won't get recogniced when opening the dialog to set the current index of the combobox properly.

Also I think it would make sense if different palettes have a name defined in their python files instead of doing that in the settings dialog. So see this as work-in-progress if anything.

It's also not syncing changes to the settings yet.

Either way because the feature adds new translatable strings to the UI (palette names and the label in the settings panel), I would think it makes sense to keep this feature open for a future release rather than the very next. Feel free to implement the missing parts I mentioned if you don't want to wait for me to do it. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants