Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PerfRepoReport permission code #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix PerfRepoReport permission code #7

wants to merge 4 commits into from

Conversation

jtluka
Copy link
Contributor

@jtluka jtluka commented Aug 15, 2017

All these issues found while doing:

report = perf_api.report_get_by_id(report)
old_xml = report.to_xml()
new_report = PerfRepoReport(old_xml)

The report must contain some permissions.

@jtluka
PerfRepoReport: fix parsing report without permissions
9eebd83 
When a report does not contain any permissions the object constructor fails
with an exception.

Signed-off-by: Jan Tluka <jtluka@redhat.com>
@jtluka
PerfRepoReport: include permissions in output of to_xml() method
967d0cc 
Signed-off-by: Jan Tluka <jtluka@redhat.com>
@jtluka
PerfRepoReportPermission: remove search for non-existent id tag
8622aed 
Signed-off-by: Jan Tluka <jtluka@redhat.com>
@jtluka
PerfRepoReportPermission: use correct tag for permission in to_xml() …
b015947 
…output

Signed-off-by: Jan Tluka <jtluka@redhat.com>
@olichtne
Copy link
Owner

olichtne commented Dec 8, 2017

This needs to be re-thought and reworked because Report permissions are serialized into XMLs with different schema depending on whether they're being sent to PerfRepo to attach to a report and when they're received from PerfRepo along with report data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtluka @olichtne