Add Linux compatibility (different approach) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the CMake config: - Relax minimum CMake version requirement. - The Swift compiler is not configured by setting CMAKE_Swift_COMPILER. We no longer look consider the TOOLCHAINS variable because it's macOS-specific as far as I know. - You must specify the full path to swiftc in CMAKE_Swift_COMPILER, as opposed to toolchain's bundle identifier in the TOOLCHAINS variable. Example for macOS: `cmake -DCMAKE_Swift_COMPILER=/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2023-12-07-a.xctoolchain/usr/bin/swiftc` - Verify that the Swift compiler supports Embedded Swift and abort if it doesn't.
|
Discussion: #1 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementing @libewa's work in #1, this is my alternative approach to adding Linux compatibility (plus some other small formatting and documentation changes). We should merge either #1 or this one or possibly a combination of both.