Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt of go-pgo #3134

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

opt of go-pgo #3134

wants to merge 12 commits into from

Conversation

chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #3134 (762c568) into dev (7fdb0ea) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 762c568 differs from pull request most recent head c76a3ba. Consider uploading reports for the commit c76a3ba to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3134   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files         441      441           
  Lines       46270    46270           
=======================================
+ Hits        16678    16680    +2     
+ Misses      28354    28353    -1     
+ Partials     1238     1237    -1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants