Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocksdb Option Parameter Misspelling info #3045

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

bylingo
Copy link
Contributor

@bylingo bylingo commented Mar 24, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@bylingo bylingo force-pushed the bylingo/2010-rocksdb-parameter-misspelling-info branch from d80fe45 to 4c4c005 Compare March 24, 2023 02:37
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #3045 (aad8994) into dev (a701f9d) will decrease coverage by 0.17%.
The diff coverage is 9.50%.

❗ Current head aad8994 differs from pull request most recent head e52edbb. Consider uploading reports for the commit e52edbb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3045      +/-   ##
==========================================
- Coverage   36.24%   36.08%   -0.17%     
==========================================
  Files         428      434       +6     
  Lines       44860    45124     +264     
==========================================
+ Hits        16261    16281      +20     
- Misses      27425    27668     +243     
- Partials     1174     1175       +1     
Impacted Files Coverage Δ
x/distribution/keeper/cm45querier.go 0.00% <0.00%> (ø)
x/distribution/keeper/keeper_grpc_adapter.go 0.00% <0.00%> (ø)
x/distribution/keeper/querier.go 68.67% <0.00%> (-1.70%) ⬇️
x/distribution/types/params.go 35.52% <0.00%> (-1.46%) ⬇️
x/distribution/types/querier.go 0.00% <0.00%> (ø)
x/evm/watcher/querier.go 0.00% <ø> (ø)
x/evm/watcher/types.go 39.07% <0.00%> (-0.32%) ⬇️
x/gov/keeper/cm45querier.go 0.00% <0.00%> (ø)
x/gov/keeper/querier.go 76.25% <0.00%> (-2.26%) ⬇️
x/gov/types/cm45_rest_adapter.go 0.00% <0.00%> (ø)
... and 17 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bylingo bylingo marked this pull request as ready for review March 24, 2023 09:24
@@ -129,5 +133,51 @@ func CheckStart() error {
}
}

rocksDBMisspelling(ctx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can find a more common way to do the check, just like sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants