refactor(switch): update component #480
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
Cr0zy07
force-pushed
the
refactor/switch-358
branch
from
a67d3cc
to
095ea6b
Compare
Cr0zy07
commented
Jan 4, 2024
Comment on lines
+34
to
+45
| watchEffect(() => { | ||
| const input = inputRef.value! | ||
| const inputProto = window.HTMLInputElement.prototype | ||
| const descriptor = Object.getOwnPropertyDescriptor(inputProto, 'checked') as PropertyDescriptor | ||
| const setChecked = descriptor.set | ||
|
|
||
| if (prevChecked.value !== checked.value && setChecked) { | ||
| const event = new Event('click', { bubbles: bubbles.value }) | ||
| setChecked.call(input, checked.value) | ||
| input.dispatchEvent(event) | ||
| } | ||
| }) |
There was a problem hiding this comment.
bubble-input does not bubble up checked change, I'm not sure if there is an issue here or not.
Comment on lines
90
to
99
| if (isFormControl.value) { | ||
| // TODO: isPropagationStopped() is not supported in vue | ||
| // hasConsumerStoppedPropagationRef.value = event.isPropagationStopped() | ||
|
|
||
| // if switch is in a form, stop propagation from the button so that we only propagate | ||
| // one click event (from the input). We propagate changes from an input so that native | ||
| // form validation works and form events reflect switch updates. | ||
| if (!hasConsumerStoppedPropagationRef.value) | ||
| event.stopPropagation() | ||
| } |
There was a problem hiding this comment.
or the bubble up events issue is related to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
cc #358
Additional context