refactor(toolbar): update component #454
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
productdevbook
approved these changes
Dec 18, 2023
chore: update snapshots
Cr0zy07
force-pushed
the
refactor/toolbar-358
branch
from
6b5d0c3
to
398c0c1
Compare
|
Here's a demo video of the issue: |
Cr0zy07
force-pushed
the
refactor/toolbar-358
branch
from
fbdb755
to
fa11427
Compare
Cr0zy07
commented
Dec 19, 2023
Comment on lines
29
to
30
| ...mergeProps(attrs, otherProps), | ||
| orientation: computed(() => inject.orientation.value === 'horizontal' ? 'vertical' : 'horizontal').value, |
There was a problem hiding this comment.
I just reordered them, and it works. I think the orientation get override by the orientation in the otherProps.
productdevbook
approved these changes
Jan 5, 2024
Cr0zy07
force-pushed
the
refactor/toolbar-358
branch
from
307c27d
to
fa11427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
cc #358
Additional context