This repository has been archived by the owner on Sep 8, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roughly outlines how an sidecar-based indexer would look like.
First commit is mostly just a big code move to share functionality previously in the
store
pkg.It's not fully wired together yet (no API) but one can play with the test skeleton in the index package (BYO log file), which implements detection and indexing of new segments and allows querying them.
The trigram is "only" a pre-filtering optimization, i.e. may yield false positives that need to be checked, which can be anything between 0 and all records of a segment, depending on how well we could extract trigrams from a given regex.
As a result, observed speedups vary from 5-200x. Storage overhead for relatively uniform logs (e.g. webserver logs) appears to be ~70% of the raw data.
Main concern is probably indexing speed at only ~13MB/sec single-threaded.
Probably best to get #120 in before continuing here.