Prefer media.ccc.de over YouTube #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If media.ccc.de link is present use it for the iframe instead of YouTube - If no media.ccc.de link is present fallback to YouTube - Add YouTube link to the "LINKS" Sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduces the function that the media.ccc.de embed is preferred over the YouTube embed.
As we already have a custom field (
mediaccc)that contains the full link to media.ccc.de this only adds the/oembedto the end of the URL and display's it in a iframe similar to the one that displays the YouTube content. If we at some point switch from the full URL to the ID as we do with YouTube this needs to be changed. (But as all the field inputs need to be changed as well I think we'll stick to the full URL..)If the
mediaccccustom field is not set, the YouTube ID will be used and the "old" iframe will be shown.Changes in this MR: