Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ redesign newsletter archive, allow limits + filtering in plugin #498

Merged
merged 2 commits into from May 6, 2024

Conversation

krmax44
Copy link
Member

@krmax44 krmax44 commented Apr 25, 2024

this will delete all currently existing newsletter archive plugins from the site, as this pr adds a model to the plugin

@pajowu
Copy link
Member

pajowu commented Apr 26, 2024

Can we do this without deleting all plugins (for example with a migrations that places them in the right spot again?)

@krmax44
Copy link
Member Author

krmax44 commented May 6, 2024

@pajowu TL;DR: Not worth the workarounds here, since it's only used in one instance. See django-cms/django-cms#7476.

@krmax44 krmax44 force-pushed the krmax44/newsletter-archive branch from e153c7f to 4ea4a4f Compare May 6, 2024 13:10
@krmax44 krmax44 force-pushed the krmax44/newsletter-archive branch from 4ea4a4f to 378ba23 Compare May 6, 2024 13:10
@krmax44 krmax44 enabled auto-merge (rebase) May 6, 2024 13:12
@krmax44 krmax44 merged commit 6303402 into main May 6, 2024
3 checks passed
@krmax44 krmax44 deleted the krmax44/newsletter-archive branch May 6, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants