Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prov/verbs: Allow for large TX queues with limited (or no) inline data #9940

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

prov/verbs: Allow for large TX queues with limited (or no) inline data #9940

wants to merge 3 commits into from
+32 −92

Commits on Apr 19, 2024

  1. prov/verbs: Remove assert(cq) from vrb_find_max_inline() 

    It's better to return from vrb_find_max_inline() if the CQ cannot
be created.

Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
    @sydidelot
    sydidelot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f06067e View commit details
    Browse the repository at this point in the history

  2. prov/verbs: Allow for large TX queues with limited (or no) inline data 

    Using large TX queues with the verbs provider would cause fi_getinfo()
to return an empty list of verbs adapters because the call to
ibv_create_qp() executed as part of fi_getinfo() would fail with EINVAL.

The failure happens because the code allocates the QP with the maximum
amount of inline data supported by the adapter, which is empirically
determined by vrb_find_max_inline(). The problem is that using inline
data limits the TX queue size that can be allocated.

The patch removes vrb_get_qp_cap(), whose the sole purpose is to set
the maximum inline data size returned by vrb_find_max_inline(). This
operation can be done in vrb_get_device_attrs() directly.

Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
    @sydidelot
    sydidelot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    99c220e View commit details
    Browse the repository at this point in the history

  3. prov/verbs: Remove the word "maximum" from the env variable labels 

    These environment variables define the default values when no hints
are provided. Remove the word "maximum" to avoid confusion over
whether these are a default value or a maximum value.

Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
    @sydidelot
    sydidelot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3403a1f View commit details
    Browse the repository at this point in the history