Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/cxi: Configury fixes #9793

Closed
wants to merge 2 commits into from
Closed

prov/cxi: Configury fixes #9793

wants to merge 2 commits into from

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Feb 6, 2024

These patches were used to successfully build the cxi provider on the Aurora system at Argonne with non-standard curl and json-c library installs.

The configure option is --with-json-c, so we need to check
$with_json_c, not $with_json.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
@thomasgillis
Copy link
Contributor

this PR solves my issue on LUMI #9789, thanks for the help @raffenet

@jswaro jswaro closed this Feb 7, 2024
@hppritcha
Copy link
Contributor

@thomasgillis @raffenet
I applied these patches to CXI provider on our LANL system but when it comes to linking I''m seeing this:

In file included from prov/cxi/src/cxip_if.c:19:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
 2799 |         return cxi_cq_empty(cmdq->dev_cmdq);
      |                ^~~~~~~~~~~~
      |                cxi_eq_empty
  CC       prov/cxi/src/src_libfabric_la-cxip_fabric.lo
In file included from prov/cxi/src/cxip_fabric.c:20:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-function-declaration]
 2799 |         return cxi_cq_empty(cmdq->dev_cmdq);
      |                ^~~~~~~~~~~~
      |                cxi_eq_empty
  CC       prov/cxi/src/src_libfabric_la-cxip_repsum.lo
In file included from prov/cxi/src/cxip_repsum.c:18:
./prov/cxi/include/cxip.h: In function 'cxip_cmdq_empty':
./prov/cxi/include/cxip.h:2799:16: warning: implicit declaration of function 'cxi_cq_empty'; did you mean 'cxi_eq_empty'? [-Wimplicit-fu

and then when it comes to linking that symbol cxi_cq_empty is undefined.

we are currently running sshot2.0.2.

Should I use git@github.com:thomasgillis/libfabric.git. instead?

@thomasgillis
Copy link
Contributor

@hppritcha Yes, it seems that you have the same issue as I had on LUMI :-)
There is a branch on my fork that should work, see details here: #9835

@hppritcha
Copy link
Contributor

hmmm... thanks @thomasgillis rather disturbingly if you configure with --enable-debug additional hacking is required on the cxi provider code.

@raffenet
Copy link
Contributor Author

FWIW, I've reached out to folks at ALCF to see if there's anything that can be done to support, at minimum, build testing of cxi on the Polaris machine here at Argonne. Ideally, once cxi is able to build on a production system, CI could prevent further breaking changes from going in. @jswaro is that something that would be of interest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants