prov/efa: Support unsolicited RDMA write with immediate receive #10036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
commented
May 13, 2024
shijin-aws
force-pushed
the
unsolicited_rdma_write
branch
2 times, most recently
from
e8fbd11
to
dec5878
Compare
|
Need to rebase on #10042 |
This patch onboards Libfabric with the rdma-core feature that supports unsolicited RDMA write with immediate receive linux-rdma/rdma-core#1459 . When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
unsolicited_rdma_write
branch
from
dec5878
to
a1cac3e
Compare
|
@mrgolin can you review it, thanks |
Comment on lines
+151
to
+160
| if (!efa_rdm_cq_wc_is_unsolicited(ibv_cq_ex)) { | ||
| /** | ||
| * Recv with immediate will consume a pkt_entry, but the pkt is not | ||
| * filled, so free the pkt_entry and record we have one less posted | ||
| * packet now. | ||
| */ | ||
| assert(pkt_entry); | ||
| ep->efa_rx_pkts_posted--; | ||
| efa_rdm_pke_release_rx(pkt_entry); | ||
| } |
There was a problem hiding this comment.
Is this block supposed to be guarded with a directive? E.g. #if HAVE_CAPS_UNSOLICITED_WRITE_RECV
There was a problem hiding this comment.
efa_rdm_cq_wc_is_unsolicited is defined for both HAVE_CAPS_UNSOLICITED_WRITE_RECV=1 and HAVE_CAPS_UNSOLICITED_WRITE_RECV=0. For the latter one, it will just return false
darrylabbate
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch onboards EFA provider with the rdma-core feature that supports unsolicited RDMA write with immediate receive
linux-rdma/rdma-core#1459
. When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters.