Skip to content

Commit

Permalink
[Freesat 28.2] Upate provider names
Browse files Browse the repository at this point in the history 
Some names were identical.
Region keys not changed, so only impact on users is the displayed name.
  • Loading branch information
@AbuBaniaz
AbuBaniaz committed Dec 12, 2023
1 parent 30dde75 commit 3fd71b6
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions AutoBouquetsMaker/providers/sat_282_freesat.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
/>
<dvbsconfigs>
<configuration key="hd_freesat_110_1" bouquet="0x110" region="0x1">BBC London/ITV London</configuration>
<configuration key="hd_freesat_110_2" bouquet="0x110" region="0x2">BBC East (W)/ITV Anglia W</configuration>
<configuration key="hd_freesat_110_2" bouquet="0x110" region="0x2">BBC East (W)/ITV Anglia W 0x2</configuration>
<configuration key="hd_freesat_110_3" bouquet="0x110" region="0x3">BBC East (W)/ITV Central S</configuration>
<configuration key="hd_freesat_110_4" bouquet="0x110" region="0x4">BBC East (W)/ITV Anglia W</configuration>
<configuration key="hd_freesat_110_4" bouquet="0x110" region="0x4">BBC East (W)/ITV Anglia W 0x4</configuration>
<configuration key="hd_freesat_110_5" bouquet="0x110" region="0x5">BBC W Mids/ITV Central W</configuration>
<configuration key="hd_freesat_110_6" bouquet="0x110" region="0x6">BBC W Mids/ITV Central SW</configuration>
<configuration key="hd_freesat_110_7" bouquet="0x110" region="0x7">BBC N West/ITV Granada</configuration>
<configuration key="hd_freesat_110_7" bouquet="0x110" region="0x7">BBC N West/ITV Granada 0x7</configuration>
<configuration key="hd_freesat_110_8" bouquet="0x110" region="0x8">BBC N West/ITV BorderEng</configuration>
<configuration key="hd_freesat_110_9" bouquet="0x110" region="0x9">BBC EYrks&amp;Lin/ITV Yorkshire E</configuration>
<configuration key="hd_freesat_110_a" bouquet="0x110" region="0xa">BBC Yorkshire/ITV Yorkshire W</configuration>
<configuration key="hd_freesat_110_a" bouquet="0x110" region="0xa">BBC Yorkshire/ITV Yorkshire W 0xa</configuration>
<configuration key="hd_freesat_110_b" bouquet="0x110" region="0xb">BBC Yorkshire/ITV Yorkshire E</configuration>
<configuration key="hd_freesat_110_c" bouquet="0x110" region="0xc">BBC Yorkshire/ITV Tyne Tees S</configuration>
<configuration key="hd_freesat_110_d" bouquet="0x110" region="0xd">BBC E Midlands/ITV Central E</configuration>
Expand Down Expand Up @@ -57,10 +57,10 @@
<configuration key="hd_freesat_110_24" bouquet="0x110" region="0x24">BBC NE &amp; C/ITV Tyne Tees S</configuration>
<configuration key="hd_freesat_110_25" bouquet="0x110" region="0x25">BBC Oxford/ITV Central S</configuration>
<configuration key="hd_freesat_110_26" bouquet="0x110" region="0x26">BBC Oxford/ITV London</configuration>
<configuration key="hd_freesat_110_27" bouquet="0x110" region="0x27">BBC N West/ITV Granada</configuration>
<configuration key="hd_freesat_110_28" bouquet="0x110" region="0x28">BBC Yorkshire/ITV Yorkshire W</configuration>
<configuration key="hd_freesat_110_27" bouquet="0x110" region="0x27">BBC N West/ITV Granada 0x27</configuration>
<configuration key="hd_freesat_110_28" bouquet="0x110" region="0x28">BBC Yorkshire/ITV Yorkshire W 0x28</configuration>
<configuration key="hd_freesat_110_29" bouquet="0x110" region="0x29">BBC Channel Is/ITV Channel Is</configuration>
<configuration key="hd_freesat_110_2a" bouquet="0x110" region="0x2a">BBC Yorkshire/ITV Yorkshire W</configuration><!-- West -->
<configuration key="hd_freesat_110_2a" bouquet="0x110" region="0x2a">BBC Yorkshire/ITV Yorkshire W 0x2a</configuration><!-- West -->
<configuration key="hd_freesat_110_2b" bouquet="0x110" region="0x2b">BBC Isle of Man</configuration>
<configuration key="hd_freesat_111_3c" bouquet="0x111" region="0x3c">BBC Scotland/STV North</configuration>
<configuration key="hd_freesat_111_3d" bouquet="0x111" region="0x3d">BBC Scotland/STV Tayside</configuration>
Expand Down

3 comments on commit 3fd71b6

@Huevos
Copy link
Member

@Huevos Huevos commented on 3fd71b6 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is having a hex value in the region name user friendly?

@AbuBaniaz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And having multiple entries where users could not tell they are different was? Most people scroll left/right instead of opening up the list so would not even know there was more than one. I added the region which is in hex value in the provider file so they are distinguishable. Feel free to revert/improve.

I suspect there will be more changes after the SD channels are switched off.

@Huevos
Copy link
Member

@Huevos Huevos commented on 3fd71b6 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SD, I don't know. Currently we are already only using the HD regions for Freesat bouquets.

So my question is what difference is there between the different versions of the same region. If nothing then they should be commented out in the xml file. They will continue to work for current users but will no longer be selectable.

Please sign in to comment.