gito - Technical Training #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atovange
force-pushed
the
17.0-technical-training-gito
branch
from
68635a6
to
7cdfb7a
Compare
qle-odoo
reviewed
Apr 17, 2024
estate/models/property.py
Outdated
| total_area = fields.Float(string="Total Area (sqm)", compute="_compute_total_area") | ||
| best_offer = fields.Float(compute="_compute_best_offer") | ||
|
|
||
| _sql_constraints = [ |
There was a problem hiding this comment.
put your constraint at the top of your class, after _description
qle-odoo
reviewed
Apr 17, 2024
estate/models/property.py
Outdated
| for property in self: | ||
| if float_utils.float_is_zero(property.selling_price, precision_digits=2): | ||
| continue | ||
| if float_utils.float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0: |
There was a problem hiding this comment.
Not 2 if.
if ( bool(x) and bool(y) ):
raise blablabla
qle-odoo
reviewed
Apr 17, 2024
estate/models/property_offer.py
Outdated
| validity = fields.Integer(default=7) | ||
| date_deadline = fields.Date(compute="_compute_deadline", inverse="_inverse_deadline") | ||
|
|
||
| sql_constraints = [ |
There was a problem hiding this comment.
Suggested change
| sql_constraints = [ | |
| _sql_constraints = [ |
added 14 commits
April 18, 2024 09:51
Atovange
force-pushed
the
17.0-technical-training-gito
branch
from
f8acfdd
to
905eb07
Compare
added 11 commits
April 18, 2024 11:02
added 4 commits
April 26, 2024 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.