aaha - Technical Training #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchu-odoo
reviewed
Mar 19, 2024
vchu-odoo
reviewed
Mar 21, 2024
estate/models/estate_property.py
Outdated
| name = fields.Char(required=True, string="Title") | ||
| description = fields.Text(string="Description") | ||
| postcode = fields.Char(string="Postcode") | ||
| date_availability = fields.Date(default=fields.Date.add(fields.Date.today(), days=90), copy=False, string="Available From") |
There was a problem hiding this comment.
Not all months consist of 30 days, so to be more precise you can use months option.
Suggested change
| date_availability = fields.Date(default=fields.Date.add(fields.Date.today(), days=90), copy=False, string="Available From") | |
| date_availability = fields.Date(default=fields.Date.add(fields.Date.today(), months=3), copy=False, string="Available From") |
estate/models/estate_property.py
Outdated
Comment on lines
29
to
30
| ('offer received', 'Offer Received'), | ||
| ('offer accepted', 'Offer Accepted'), |
There was a problem hiding this comment.
By convention we use pyhon-like style.
Suggested change
| ('offer received', 'Offer Received'), | |
| ('offer accepted', 'Offer Accepted'), | |
| ('offer_received', 'Offer Received'), | |
| ('offer_accepted', 'Offer Accepted'), |
| <field name="bedrooms"/> | ||
| <field name="living_area"/> | ||
| <field name="facades"/> | ||
| <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer received')]"/> |
There was a problem hiding this comment.
As an alternative way you can write:
Suggested change
| <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer received')]"/> | |
| <filter name="available" string="Available" domain="[('state', 'in', ('new', 'offer_received'))]"/> |
estate/__manifest__.py
Outdated
| @@ -0,0 +1,11 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Since recently it is not needed to add this line anymore.
Suggested change
| # -*- coding: utf-8 -*- |
vchu-odoo
reviewed
Mar 26, 2024
Comment on lines
39
to
43
| <header> | ||
| <button name="action_set_sold" type="object" string="SOLD" invisible="state == 'sold'"/> | ||
| <button name="action_set_canceled" type="object" string="CANCEL" invisible="state == 'sold'"/> | ||
| <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/> | ||
| </header> |
There was a problem hiding this comment.
header should be before sheet according to the tutorial
| @@ -0,0 +1,104 @@ | |||
| <?xml version="1.0"?> | |||
| <odoo> | |||
| <record id="estate_property_action" model="ir.actions.act_window"> | |||
There was a problem hiding this comment.
usually we put actions after the views declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.