[FW][FIX] pos : product images look zoomed in #163725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cover scss rule first stretches the image to fill the container completely, then cropped at the size of the container. This results in some poor display result if the image has a weird aspect ratio. This is a behaviour change from saas-16.3 where the image wasn't cropped and simply resized to fit inside the container. opw-3826349 X-original-commit: f0d0e9c
|
@loleloup @vlst-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2024
The cover scss rule first stretches the image to fill the container completely, then cropped at the size of the container. This results in some poor display result if the image has a weird aspect ratio. This is a behaviour change from saas-16.3 where the image wasn't cropped and simply resized to fit inside the container. opw-3826349 closes #163725 X-original-commit: f0d0e9c Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com> Signed-off-by: Loïc Leloup (lole) <lole@odoo.com>
fw-bot
deleted the
master-saas-16.4-pos_fix_product_image_fit-lole-_oZs-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cover scss rule first stretches the image to fill the container completely, then cropped at the size of the container.
This results in some poor display result if the image has a weird aspect ratio.
This is a behaviour change from saas-16.3 where the image wasn't cropped and simply resized to fit inside the container.
opw-3826349
saas-16.3:
saas-16.4:
fixed locally (16.4):
Forward-Port-Of: #161111
Forward-Port-Of: #161038