New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website: remove navbar extra padding #163705
Conversation
In the mobile view, the header has extra padding, for this reason it is not perfectly aligned with the content of the page.
40cfc68
to
c706f3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qsm-odoo This one should make you happy :o
Visually LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with that in 17.0. In master, we'll just change the use of $navbar-padding-x
. And later maybe do even better (task-2241779).
Thanks ! 👍
@robodoo r+
I didn't want to use |
I want to create the fix for 16, @qsm-odoo do you want me to use |
Yes, that's good, that's why I merged it 👍
No, I am changing that for the master version but we should not in stable versions. I actually found other bugs when navbar-padding-x is equal to 0, I am fixing for master. For master, forcing the main navbar padding with a padding class is good 👍 |
In the mobile view, the header has extra padding, for this reason it is not perfectly aligned with the content of the page. closes odoo#163705 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@imanie383 @qsm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
@imanie383 @qsm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@imanie383 @qsm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Description of the issue/feature this PR addresses:
In the mobile view, the header has extra padding, for this reason it is not perfectly aligned with the content of the page.
Current behavior before PR:
The header is not aligned with the content
Desired behavior after PR is merged:
The header is aligned with the content like desktop view
2024-04-28.09-07-05.mp4
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr