[IMP] add ${VAR} variables in paths #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Remove pythonPath field from Config view - Integrate Python extension - Properly use async/await in the code. - Use of global.d.ts for Global variables. - Wait for LanguageClient to stop before starting it again - Queue Configuration change when LanguageClient is still stopping - Properly hide Crash notification test command in Production - outputChannel is now stored globally instead of being passed to all functions - Logging is now done through LanguageClient - Add a Bash shebang to build_package.sh Co-authored by Solan (sode)
… python extension Changes: - check if python extension is ready and save it in global - display python path in config when relevant - check and prepare the environment without python extension
The main goal of this commit is to be able not to set pythonPath when the extension is disabled
/!\ there's probably still a bug on windows
Louciole
changed the title
goal : odooPath processing must be accessible in utils, It must be generic
/!\ changing structure of configuration from : - odooPath to - rawOdooPath - path saved in the configuration - odooPath - path evaluated (default to path saved in configuration to preserve back compatibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be merged AFTER the migration to python Extension (#85)
It adds :
the user can put two variables in their odoo path to make their configuration simpler and dynamic.
This also implements a helper to inform the user of this feature.