New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] clipboard: improve cut formula behaviour #4152
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
added a commit
that referenced
this pull request
Apr 30, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in sheet2, the pasted formula would refer to `A1` in sheet2. The more correct behaviour is to refer to `A1` in sheet1, transforming the pasted formula to `=Sheet1!A1`. Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2, we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2. Task: 3898438
hokolomopo
force-pushed
the
master-cut-formula-adrm
branch
from
April 30, 2024 13:20
9b7edf3
to
eade79c
Compare
hokolomopo
added a commit
that referenced
this pull request
Apr 30, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in sheet2, the pasted formula would refer to `A1` in sheet2. The more correct behaviour is to refer to `A1` in sheet1, transforming the pasted formula to `=Sheet1!A1`. Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2, we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2. Task: 3898438
hokolomopo
added a commit
that referenced
this pull request
May 2, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in sheet2, the pasted formula would refer to `A1` in sheet2. The more correct behaviour is to refer to `A1` in sheet1, transforming the pasted formula to `=Sheet1!A1`. Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2, we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2. Task: 3898438
Previously, when cutting a formula `=A1` in sheet1, and pasting it in sheet2, the pasted formula would refer to `A1` in sheet2. The more correct behaviour is to refer to `A1` in sheet1, transforming the pasted formula to `=Sheet1!A1`. Also when cutting a formula `=Sheet2!A1` from sheet1 to sheet2, we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2. Task: 3898438
LucasLefevre
force-pushed
the
master-cut-formula-adrm
branch
from
May 10, 2024 08:28
eade79c
to
181e9f5
Compare
LucasLefevre
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
robodoo
pushed a commit
that referenced
this pull request
May 10, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in sheet2, the pasted formula would refer to `A1` in sheet2. The more correct behaviour is to refer to `A1` in sheet1, transforming the pasted formula to `=Sheet1!A1`. Also when cutting a formula `=Sheet2!A1` from sheet1 to sheet2, we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2. closes #4152 Task: 3898438 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when cutting a formula
=A1
in sheet1, and pasting it in sheet2, the pasted formula would refer toA1
in sheet2. The more correct behaviour is to refer toA1
in sheet1, transforming the pasted formula to=Sheet1!A1
.Also when cutting a formula
=Sheet2!A1
from sheet1 tp sheet2, we can drop the prefixSheet2!
and only paste=A1
in sheet2.Task: : 3898438
review checklist