Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] clipboard: improve cut formula behaviour #4152

Closed
wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

Previously, when cutting a formula =A1 in sheet1, and pasting it in sheet2, the pasted formula would refer to A1 in sheet2. The more correct behaviour is to refer to A1 in sheet1, transforming the pasted formula to =Sheet1!A1.

Also when cutting a formula =Sheet2!A1 from sheet1 tp sheet2, we can drop the prefix Sheet2! and only paste =A1 in sheet2.

Task: : 3898438

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2024

hokolomopo added a commit that referenced this pull request Apr 30, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in
sheet2, the pasted formula would refer to `A1` in sheet2. The more
correct behaviour is to refer to `A1` in sheet1, transforming the
pasted formula to `=Sheet1!A1`.

Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2,
we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2.

Task: 3898438
hokolomopo added a commit that referenced this pull request Apr 30, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in
sheet2, the pasted formula would refer to `A1` in sheet2. The more
correct behaviour is to refer to `A1` in sheet1, transforming the
pasted formula to `=Sheet1!A1`.

Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2,
we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2.

Task: 3898438
hokolomopo added a commit that referenced this pull request May 2, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in
sheet2, the pasted formula would refer to `A1` in sheet2. The more
correct behaviour is to refer to `A1` in sheet1, transforming the
pasted formula to `=Sheet1!A1`.

Also when cutting a formula `=Sheet2!A1` from sheet1 tp sheet2,
we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2.

Task: 3898438
Previously, when cutting a formula `=A1` in sheet1, and pasting it in
sheet2, the pasted formula would refer to `A1` in sheet2. The more
correct behaviour is to refer to `A1` in sheet1, transforming the
pasted formula to `=Sheet1!A1`.

Also when cutting a formula `=Sheet2!A1` from sheet1 to sheet2,
we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2.

Task: 3898438
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request May 10, 2024
Previously, when cutting a formula `=A1` in sheet1, and pasting it in
sheet2, the pasted formula would refer to `A1` in sheet2. The more
correct behaviour is to refer to `A1` in sheet1, transforming the
pasted formula to `=Sheet1!A1`.

Also when cutting a formula `=Sheet2!A1` from sheet1 to sheet2,
we can drop the prefix `Sheet2!` and only paste `=A1` in sheet2.

closes #4152

Task: 3898438
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this May 10, 2024
@robodoo robodoo added the 17.3 label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants