Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Export xlsx: export value for non-exportable formulas #4146

Closed

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Apr 26, 2024

The recent fix in #3622 combined with a slight refactoring of the export for Excel in #2090 let to a situation where cells with non-exportable formulas containing references did not have their content replaced by the evaluated result.

Task: 3895465

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

Task: 3895465
@robodoo
Copy link
Collaborator

robodoo commented Apr 26, 2024

Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 27, 2024
The recent fix in #3622
combined with a slight refactoring of the export for Excel in
#2090 let to a situation where
cells with non-exportable formulas containing references did not have
their content replaced by the evaluated result.

closes #4146

Task: 3895465
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Apr 27, 2024
@fw-bot
Copy link
Collaborator

fw-bot commented May 1, 2024

@rrahir @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Collaborator

fw-bot commented May 2, 2024

@rrahir @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 3, 2024

@rrahir @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants