[IMP] highlight: add drag & drop to array formula highlight #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
changed the title
hokolomopo
force-pushed
the
master-drag-and-drop-array-formula-adrm
branch
2 times, most recently
from
31b24ba
to
352822f
Compare
We sometime need to create a UI plugin specifically to handle a command so that its sub-commands are batched in a single history step. This is kind of a problem when working with stores, because then we need both a store to handle all the business logic, and a plugin that handle a command created specifically to batch sub-commands (looking at you find & replace). We can fix that easily by creating a local command `BATCH_COMMANDS` that take a callback as argument, and that batches every command and sub-command executed in the callback within one history step. Task: 3870119
Now that we can batch commands, the plugin find & replace is now useless. Task: 3870119
The component that handle highlight's UI interactions is named `Highlight`, which is the same as the type `Highlight`. This is annoying because we always end up importing the wrong `Highlight`, and need named imports if we want to use both the type and the component in a file. This commit renames the component to `HighlightOverlay` Task: 3869873
The hitbox for the borders of the highlight was not very well placed. There was some margins computations, I'm assuming they were there to avoid overlapping with the highlight corners but they were both wrong (there was overlap) and useless (the corner is above the border). The highlight border was also not centered on the cell border, and was quite small, making it hard to click. This commit removed the "margins", and widened and centered the borders. Task: 3869873
With this commit, it is now possible to drag & drop an array formula by clicking on its highlight. Task 3869873
hokolomopo
force-pushed
the
master-drag-and-drop-array-formula-adrm
branch
from
352822f
to
e050917
Compare
hokolomopo
commented
Apr 16, 2024
| @@ -353,7 +353,7 @@ function constructZonesFromProfiles( | |||
| pendingZones = nextPendingZones; | |||
| } | |||
| mergedZone.push(...pendingZones); | |||
| return mergedZone; | |||
| return mergedZone as T[]; | |||
There was a problem hiding this comment.
Not really happy about that but it's mighty annoying to type...
The rationale is that, as far as I know, calling recomputeZones on only Zones (and no unbounded zones) will always return Zones. So it'd be nice if it was typed as such.
The fact that it's typed as returning UnboundedZones make it very annoying to use for simple cases where we only handle zones. Do you have any good ideas @laa-odoo ?
There was a problem hiding this comment.
Indeed, this is never supposed to happen: recompute non-UnboundedZones will always give non-UnBoundedZones
But it will also be complicated to type the mechanics of recomputeZone.... The best would be to force the typing within recomputeZone itself so that it doesn't bother anyone. (
imo I am for)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] highlight: add drag & drop to array formula highlight
With this commit, it is now possible to drag & drop an array formula
by clicking on its highlight.
[IMP] highlight: improve border hitbox
The hitbox for the borders of the highlight was not very well placed.
There was some margins computations, I'm assuming they were there
to avoid overlapping with the highlight corners but they we both
wrong (there was overlap) and useless (the corner is above the border).
The highlight border was also not centered on the cell border, and
was quite small, making it hard to click.
This commit removed the "margins", and widened and centered the borders.
[REF] highlight: rename Highlight component:
The component that handle highlight's UI interactions is named
Highlight, which is the same as the typeHighlight. This is annoyingbecause we always end up importing the wrong
Highlight, and neednamed imports if we want to use both the type and the component in a
file.
This commit renames the component to
HighlightOverlayTask: : 3869873
review checklist