New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] clipboard: keep cell formatting when copy/pasting cells from one spreadsheet to another #4053
Open
Rachico
wants to merge
1
commit into
master
Choose a base branch
from
master-copy-paste-to-other-spreadsheets-mera
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
5 times, most recently
from
April 15, 2024 09:43
7a773c4
to
8f650d2
Compare
Rachico
changed the title
[IMP] Keep cell formatting when copy/pasting data from a spreadsheet to another
[IMP] clipboard: keep cell formatting when copy/pasting data from a spreadsheet to another
Apr 15, 2024
Rachico
changed the title
[IMP] clipboard: keep cell formatting when copy/pasting data from a spreadsheet to another
[IMP] clipboard: keep cell formatting when copy/pasting cells from a spreadsheet to another
Apr 15, 2024
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
2 times, most recently
from
April 15, 2024 14:21
0c59953
to
c5c78c4
Compare
Rachico
changed the title
[IMP] clipboard: keep cell formatting when copy/pasting cells from a spreadsheet to another
[IMP] clipboard: keep cell formatting when copy/pasting cells from one spreadsheet to another
Apr 15, 2024
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
4 times, most recently
from
April 16, 2024 13:24
f2bee9d
to
4c94ede
Compare
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
5 times, most recently
from
April 26, 2024 10:08
f9fcdec
to
b140631
Compare
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
2 times, most recently
from
May 6, 2024 12:01
e32b699
to
069cb8d
Compare
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
2 times, most recently
from
May 8, 2024 08:34
d659d47
to
50546cf
Compare
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
7 times, most recently
from
May 14, 2024 18:25
f4daa3d
to
61bf025
Compare
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
3 times, most recently
from
May 15, 2024 10:54
07c4101
to
8870877
Compare
…e spreadsheet to another Currently, copy/pasting cells from one spreadsheet to another external spreadsheet removes all cell formatting and only keeps cell values. This is because the model clipboard is invalidated from one instance to another. This commit solves the issue by adding a new custom type in the browser clipboard object and using the content saved in this key to re-create the cell formatting in the new spreadsheet. Task: 3597039
Rachico
force-pushed
the
master-copy-paste-to-other-spreadsheets-mera
branch
from
May 15, 2024 11:23
8870877
to
557088a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] clipboard: keep cell formatting when copy/pasting cells from one spreadsheet to another
Problem
Currently, copy/pasting cells from one spreadsheet to another external spreadsheet removes all cell formatting and only keeps cell values. This is because the model clipboard is invalidated from one instance to another.
Solution
This commit solves the issue by adding a new custom type in the browser clipboard object and using the content saved in this key to re-create the cell formatting in the new spreadsheet.
Task: 3597039
review checklist