[ADD] commodity_trading: module for commodity trading #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paso-odoo
force-pushed
the
master-commodity_trading-arpa
branch
from
9b5c166
to
298eae1
Compare
paso-odoo
force-pushed
the
master-commodity_trading-arpa
branch
2 times, most recently
from
2be0640
to
15e9762
Compare
shag-odoo
force-pushed
the
master-commodity_trading-arpa
branch
from
9ae5b11
to
7cab004
Compare
dhrs-odoo
force-pushed
the
master-commodity_trading-arpa
branch
3 times, most recently
from
84719fd
to
5a105ec
Compare
paso-odoo
commented
Feb 28, 2024
There was a problem hiding this comment.
@dhrs-odoo
Thanks for working on this PR.
Here are some technical comments.
Cheers!
commodity_trading/__manifest__.py
Outdated
| 'knowledge', | ||
| 'mrp_account', | ||
| 'product_expiry', | ||
| # 'product_images', |
There was a problem hiding this comment.
Suggested change
| # 'product_images', | |
| # 'product_images', |
?
commodity_trading/__manifest__.py
Outdated
| 'quality_mrp', | ||
| 'quality_mrp_workorder', | ||
| 'sale_mrp', | ||
| # 'sale_planning', |
commodity_trading/__manifest__.py
Outdated
Comment on lines
25
to
27
| # 'website_appointment', | ||
| # 'website_crm', | ||
| # 'website_crm_partner_assign', |
There was a problem hiding this comment.
If not needed remove it
commodity_trading/__manifest__.py
Outdated
Comment on lines
18
to
17
| 'quality_mrp', | ||
| 'quality_mrp_workorder', |
There was a problem hiding this comment.
maybe quality_mrp_workorder is enough for installing the quality_mrp
Comment on lines
12
to
25
| <field name="help"> | ||
| <![CDATA[ | ||
| <p class="o_view_nocontent_smiling_face"> | ||
| This is your new action. | ||
| </p> | ||
| <p>By default, it contains a list and a form view and possibly | ||
| other view types depending on the options you chose for your model. | ||
| </p> | ||
| <p> | ||
| You can start customizing these screens by clicking on the Studio | ||
| icon on the top right corner (you can also customize this help message there). | ||
| </p> | ||
| ]]> | ||
| </field> |
There was a problem hiding this comment.
Suggested change
| <field name="help"> | |
| <![CDATA[ | |
| <p class="o_view_nocontent_smiling_face"> | |
| This is your new action. | |
| </p> | |
| <p>By default, it contains a list and a form view and possibly | |
| other view types depending on the options you chose for your model. | |
| </p> | |
| <p> | |
| You can start customizing these screens by clicking on the Studio | |
| icon on the top right corner (you can also customize this help message there). | |
| </p> | |
| ]]> | |
| </field> |
| <field name="product_id" ref="product_product_1"/> | ||
| <field name="order_id" ref="purchase_order_1"/> | ||
| <field name="product_qty">125.0</field> | ||
| <field name="price_unit">123.0</field> |
There was a problem hiding this comment.
price_unit comes should be set in the product. If already set, we need to remove it
Comment on lines
3
to
29
| <record id="sale_order_1" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_2" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_3" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_4" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_5" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_6" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_7" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_8" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> | ||
| <record id="sale_order_9" model="sale.order"> | ||
| <field name="partner_id" ref="res_partner_8"/> | ||
| </record> |
There was a problem hiding this comment.
I would add user_id
Also need to correct the indentation
| <field name="product_id" ref="product_product_8"/> | ||
| <field name="order_id" ref="sale_order_4"/> | ||
| <field name="product_uom_qty">27.0</field> | ||
| <field name="price_unit">123.0</field> |
There was a problem hiding this comment.
price_unit should be configured in product itself.
| @@ -0,0 +1,131 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <odoo> | |||
|
|
|||
| <function name="action_done" model="stock.picking.batch"> | ||
| <value model="stock.picking.batch" eval="obj().env.ref('commodity_trading.sale_order_5').picking_ids.batch_id.id"/> | ||
| </function> | ||
|
|
dhrs-odoo
force-pushed
the
master-commodity_trading-arpa
branch
3 times, most recently
from
adbdfd1
to
c6d92cc
Compare
|
Hello @paso-odoo |
Tailored for commodity traders (e.g., soybeans, wheat) with comprehensive functions, including CRM, quality checks, and broker involvement for product quality and commissions. task-3460474
dhrs-odoo
force-pushed
the
master-commodity_trading-arpa
branch
from
c6d92cc
to
94a85c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailored for commodity traders (e.g., soybeans, wheat) with comprehensive functions, including CRM, quality checks, and broker involvement for product quality and commissions.
task-3460474