Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] pharmacy_retail: Pharmacy Retail #45

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

spe-odoo
Copy link

@spe-odoo spe-odoo commented Nov 9, 2023

@spe-odoo spe-odoo force-pushed the master-industry-pharmaceutical-shag branch from 079d447 to ccdd706 Compare November 9, 2023 06:13
@spe-odoo spe-odoo changed the base branch from 17.0 to master November 9, 2023 07:36
@spe-odoo spe-odoo changed the base branch from master to 17.0 November 9, 2023 07:40
@spe-odoo spe-odoo force-pushed the master-industry-pharmaceutical-shag branch from b10cbae to d0b0eaf Compare November 10, 2023 11:00
Copy link
Contributor

@paso-odoo paso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some basic improvements!
Please apply them several times when needed.
Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -0,0 +1,78 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# -*- coding: utf-8 -*-

""",
'author': 'Odoo S.A',
'depends': [
'account_check_printing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'account_check_printing',

pharmaceuticals_retailers/__manifest__.py Outdated Show resolved Hide resolved
'purchase_stock',
'sale_loyalty',
'sale_margin',
'sale_planning',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'sale_planning',

Remove unused dependency

<field name="name">Himalaya Baby Cream - Extra Soft &amp; Gentle, Paraben Free, 100 ml Tube</field>
<field name="sequence">14</field>
<field name="order_id" ref="pharmaceuticals_retailers.sale_order_3" />
<field name="order_partner_id" ref="pharmaceuticals_retailers.res_partner_22" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="order_partner_id" ref="pharmaceuticals_retailers.res_partner_22" />

<field name="order_id" ref="pharmaceuticals_retailers.sale_order_3" />
<field name="order_partner_id" ref="pharmaceuticals_retailers.res_partner_22" />
<field name="product_id" ref="pharmaceuticals_retailers.product_product_20" />
<field name="product_uom" ref="uom.product_uom_unit" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="product_uom" ref="uom.product_uom_unit" />

<field name="product_id" ref="pharmaceuticals_retailers.product_product_20" />
<field name="product_uom" ref="uom.product_uom_unit" />
<field name="product_uom_qty">3.0</field>
<field name="qty_delivered_method">stock_move</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="qty_delivered_method">stock_move</field>

Comment on lines 63 to 50
<record id="stock_lot_20" model="stock.lot">
<field name="name">A-003</field>
<field name="product_id" ref="pharmaceuticals_retailers.product_product_19" />
<field name="product_uom_id" ref="pharmaceuticals_retailers.uom_uom_27" />
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused lots

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused images

@dhrs-odoo dhrs-odoo force-pushed the master-industry-pharmaceutical-shag branch 12 times, most recently from b7cf96e to 0aa42e6 Compare December 6, 2023 08:51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

This setup is for pharmacy retail companies that purchase and sell products.
They maintain the stock lot wise and also manage the expiry of the lots.
""",
'author': 'Odoo S.A',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'author': 'Odoo S.A',

'demo/sale_order_line.xml',
'demo/sale_order_post.xml',
],
'application': False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'application': False,

@@ -0,0 +1,113 @@
<?xml version="1.0" encoding="UTF-8"?>
<odoo>
<record id="doctor_34fd41e9-4456-47f4-bb18-88a9886e843e" model="ir.actions.act_window">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hash

@@ -0,0 +1,71 @@
<?xml version="1.0" encoding="UTF-8"?>
<odoo>
<record id="generic_name_group_s_b0925917-99ee-4fbe-b5d5-05a4f48a825b" model="ir.model.access">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove hash

<field name="partner_id" ref="pharmaceuticals_retailers.res_partner_18" />
</record>
<record id="purchase_order_5" model="purchase.order">
<field name="partner_id" ref="pharmaceuticals_retailers.res_partner_19" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="partner_id" ref="pharmaceuticals_retailers.res_partner_19" />
<field name="partner_id" ref="res_partner_19" />

Comment on lines 96 to 91
<record id="res_partner_24" model="res.partner">
<field name="name">Marc Demo</field>
</record>
<record id="res_partner_25" model="res.partner">
<field name="name">Barak</field>
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="res_partner_24" model="res.partner">
<field name="name">Marc Demo</field>
</record>
<record id="res_partner_25" model="res.partner">
<field name="name">Barak</field>
</record>

remove if unused

<field name="order_id" ref="pharmaceuticals_retailers.sale_order_3" />
<field name="product_id" ref="pharmaceuticals_retailers.product_product_20" />
<field name="product_uom_qty">3.0</field>
<field name="price_unit">148.8</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="price_unit">148.8</field>

<odoo noupdate="1">
<record id="stock_lot_1" model="stock.lot">
<field name="name">A-001</field>
<field name="product_id" ref="pharmaceuticals_retailers.product_product_13" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="product_id" ref="pharmaceuticals_retailers.product_product_13" />
<field name="product_id" ref="product_product_13" />

<record id="stock_lot_1" model="stock.lot">
<field name="name">A-001</field>
<field name="product_id" ref="pharmaceuticals_retailers.product_product_13" />
<field name="product_uom_id" ref="pharmaceuticals_retailers.uom_uom_32" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="product_uom_id" ref="pharmaceuticals_retailers.uom_uom_32" />

related field

@dhrs-odoo dhrs-odoo force-pushed the master-industry-pharmaceutical-shag branch 2 times, most recently from c4124d7 to 6e5706b Compare December 11, 2023 10:51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

pharmaceuticals_retailers/data/ir_actions_act_window.xml Outdated Show resolved Hide resolved
<field name="type">form</field>
<field name="arch" type="xml">
<form>
<header />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<header />

<field name="type">form</field>
<field name="arch" type="xml">
<form>
<header />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<header />

<header />
<sheet string="Therapeutic Classification">
<widget name="web_ribbon" text="Archived" bg_color="text-bg-danger" />
<field name="x_active" invisible="1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="x_active" invisible="1" />

<field name="margin">5.8</field>
<field name="pricelist_id" ref="product_pricelist_3"/>
<field name="x_doctor" ref="res_partner_10"/>
<field name="amount_to_invoice">64.17</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="amount_to_invoice">64.17</field>

<record id="sale_order_line_1" model="sale.order.line" context="{'skip_task_generation': True, 'skip_purchase_generation': True}">
<field name="order_id" ref="sale_order_1" />
<field name="product_id" ref="product_product_13" />
<field name="product_uom" ref="uom_uom_32" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="product_uom" ref="uom_uom_32" />

comes from the product

<field name="order_id" ref="sale_order_4" />
<field name="product_id" ref="product_product_13" />
<field name="product_uom" ref="uom_uom_32" />
<field name="qty_to_invoice">1.0</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="qty_to_invoice">1.0</field>

<record id="sale_order_line_15" model="sale.order.line" context="{'skip_task_generation': True, 'skip_purchase_generation': True}">
<field name="order_id" ref="sale_order_3" />
<field name="product_id" ref="product_product_26" />
<field name="qty_delivered_method">manual</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="qty_delivered_method">manual</field>

Comment on lines 3 to 6
<record id="stock_lot_1" model="stock.lot">
<field name="name">A-001</field>
<field name="product_id" ref="product_product_13" />
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="stock_lot_1" model="stock.lot">
<field name="name">A-001</field>
<field name="product_id" ref="product_product_13" />
</record>

Remove unused lots

@shag-odoo shag-odoo force-pushed the master-industry-pharmaceutical-shag branch 2 times, most recently from 532dce4 to 938628b Compare December 14, 2023 06:55
@shag-odoo
Copy link
Contributor

Hello @paso-odoo
Thanks for the quick suggestion , all the changes have been implemented

Have a great day ahead 😇

Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First very quick functional review

pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/ir_ui_menu.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/ir_actions_act_window.xml Outdated Show resolved Hide resolved
@shag-odoo shag-odoo force-pushed the master-industry-pharmaceutical-shag branch from 938628b to 54a8f5e Compare December 21, 2023 09:14
@shag-odoo
Copy link
Contributor

Hello @vava-odoo
Requested changes have been implemented

Thanks for your suggestion and have a great day ahead 😇

Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shag-odoo
Thanks for the update. I listed a few other comments, before going deeper into the data.
What I don't understand is why we need new ir.model here... It seems to me none should be added.
Could you have a look?
Thanks!

pharmaceuticals_retailers/data/knowledge_article.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/data/ir_ui_menu.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/demo/sale_order_line.xml Outdated Show resolved Hide resolved
pharmaceuticals_retailers/__manifest__.py Outdated Show resolved Hide resolved
@shag-odoo shag-odoo force-pushed the master-industry-pharmaceutical-shag branch from 54a8f5e to e54af2f Compare January 23, 2024 10:24
@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch 3 times, most recently from d71a80d to f45aad7 Compare March 15, 2024 09:31
@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch from cfa4efc to 491291e Compare April 3, 2024 13:29
@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch from 491291e to 2450b0a Compare April 17, 2024 12:03
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arpa-odoo for the update!

pharmacy_retail/demo/sale_loyalty_wizard.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/res_config_settings.xml Show resolved Hide resolved
pharmacy_retail/data/ir_actions_act_window.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/ir_ui_view.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/ir_ui_view.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/product_product.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/product_template.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/uom_uom.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/res_config_settings.xml Outdated Show resolved Hide resolved
pharmacy_retail/demo/pos_config.xml Show resolved Hide resolved
@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch 6 times, most recently from a1430b9 to 6784e1a Compare April 26, 2024 07:07
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arpa-odoo
Just a few comments here, and I think it's good to go.
Cheers

pharmacy_retail/data/pos_payment_method.xml Outdated Show resolved Hide resolved
pharmacy_retail/data/ir_ui_view.xml Show resolved Hide resolved
pharmacy_retail/data/ir_ui_view.xml Outdated Show resolved Hide resolved
Comment on lines +7 to +13
<field name="payment_method_ids" eval="[
Command.link(ref('payment.payment_method_card')),
Command.link(ref('payment.payment_method_visa')),
Command.link(ref('payment.payment_method_mastercard')),
Command.link(ref('payment.payment_method_rupay')),
Command.link(ref('payment.payment_method_maestro')),
]"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch 2 times, most recently from f616114 to d74fbfd Compare May 15, 2024 10:12
@arpa-odoo arpa-odoo force-pushed the master-industry-pharmaceutical-shag branch from d74fbfd to 70187cc Compare May 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants