[ADD]car_rental: car rental #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jva-odoo
force-pushed
the
17.0-industry-car-rental-dhrs
branch
from
95024e9
to
396353e
Compare
jva-odoo
approved these changes
Nov 8, 2023
vava-odoo
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Hi @kir-odoo
Thanks for this work!
Please find below a (small 👀) list of comments. Please apply to all files.
Since this is my first PR review in industry, there may be some comments that we need to discuss, so don't hesitate to reply if you don't agree.
Cheers
vava-odoo
requested changes
Nov 21, 2023
car_rental/static/src/binary/ir_attachment/835-web.assets_frontend.css.map
Outdated
Show resolved
Hide resolved
|
Missing file: car_rental/static/description/icon.png |
dhrs-odoo
force-pushed
the
17.0-industry-car-rental-dhrs
branch
4 times, most recently
from
182aaf2
to
faf8436
Compare
dhrs-odoo
force-pushed
the
17.0-industry-car-rental-dhrs
branch
13 times, most recently
from
211067e
to
363cd93
Compare
vava-odoo
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Hi @dhrs-odoo
Still a few things to improve here.
Most important is without sale.temporal.recurrence you can't have rental prices...
Also, could you make sure the runbot is green?
Cheers
car_rental/demo/crm_lead.xml
Outdated
| <br /> | ||
| ]]> | ||
| </field> | ||
| <field name="email_normalized">megha@gmail.com</field> |
There was a problem hiding this comment.
Better be cautious
Suggested change
| <field name="email_normalized">megha@gmail.com</field> | |
| <field name="email_normalized">megha@example.com</field> |
| @@ -0,0 +1,33 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <odoo> | |||
There was a problem hiding this comment.
Do you need this file? There is no theme to apply...
dhrs-odoo
force-pushed
the
17.0-industry-car-rental-dhrs
branch
3 times, most recently
from
bdbcc0d
to
7ce9e16
Compare
…able instead of purchased or sale
…oduct.template view
dhrs-odoo
force-pushed
the
17.0-industry-car-rental-dhrs
branch
from
80a3d3c
to
58ddf6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-3460478