Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] agriculture: Agricultural Retail #18

Open
wants to merge 18 commits into
base: 17.0
Choose a base branch
from

Conversation

prra-odoo
Copy link
Contributor

@prra-odoo prra-odoo commented Oct 30, 2023

Ticket ID: 3460550

agriculture/__manifest__.py Outdated Show resolved Hide resolved
agriculture/__manifest__.py Outdated Show resolved Hide resolved
agriculture/data/account_analytic_plan.xml Outdated Show resolved Hide resolved
agriculture/data/knowledge_article.xml Outdated Show resolved Hide resolved
agriculture/data/knowledge_article_member.xml Outdated Show resolved Hide resolved
agriculture/demo/res_partner.xml Outdated Show resolved Hide resolved
agriculture/demo/website_ir_attachment.xml Outdated Show resolved Hide resolved
agriculture/demo/website_views.xml Outdated Show resolved Hide resolved
agriculture/demo/website_views.xml Outdated Show resolved Hide resolved
@jva-odoo
Copy link
Contributor

remove .zip

agriculture/data/ir_actions_server.xml Outdated Show resolved Hide resolved
agriculture/data/ir_model_fields.xml Outdated Show resolved Hide resolved
agriculture/data/ir_model_fields.xml Outdated Show resolved Hide resolved
agriculture/data/product_category.xml Outdated Show resolved Hide resolved
agriculture/data/product_pricelist.xml Outdated Show resolved Hide resolved
agriculture/demo/website.xml Outdated Show resolved Hide resolved
agriculture/demo/website.xml Outdated Show resolved Hide resolved
agriculture/demo/website_ir_attachment.xml Outdated Show resolved Hide resolved
agriculture/demo/website_ir_attachment.xml Outdated Show resolved Hide resolved
agriculture/demo/website_ir_attachment.xml Outdated Show resolved Hide resolved
@har-odoo har-odoo force-pushed the master-industry-agriculture-vrpa branch 2 times, most recently from 7362e6f to 8db6b96 Compare November 1, 2023 09:05
@jva-odoo jva-odoo added the ready PR is ready for review and integration label Nov 1, 2023
@jva-odoo
Copy link
Contributor

jva-odoo commented Nov 3, 2023

@xavieralt In testing we found a problem with the loyalty program and website page so we fixed it after the ready tag.
so check if you force push.

@xavieralt xavieralt removed their assignment Nov 6, 2023
@pimodoo pimodoo self-assigned this Nov 8, 2023
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch 2 times, most recently from b22aebf to 857d5eb Compare January 9, 2024 12:04
@dhrs-odoo dhrs-odoo changed the base branch from 17.0 to master January 9, 2024 12:06
@dhrs-odoo dhrs-odoo changed the base branch from master to 17.0 January 9, 2024 12:06
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch 2 times, most recently from a2d124d to 9184cae Compare January 19, 2024 10:35
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch from 4c35f38 to 16974a5 Compare January 25, 2024 05:00
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch 4 times, most recently from 30a0efe to 7cf799b Compare February 12, 2024 10:06
Copy link
Contributor

@paso-odoo paso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhrs-odoo
Thanks for working on this PR.
Here are some review points. also need to reduce the attachments and remove duplicate images.

Cheers!

Comment on lines 13 to 22
'website_sale_loyalty',
'knowledge',
'payment_demo',
'pos_sale',
'product_expiry',
'survey',
'crm',
'sale_purchase',
'purchase_requisition',
'theme_enark',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow standard sequence

Comment on lines 8 to 9
if len(records) > 1:
raise UserError("Only start survey for one Lead/Opportunity.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if len(records) > 1:
raise UserError("Only start survey for one Lead/Opportunity.")

Not required as server action calls from the button of form view and there is no binding_view_types

Comment on lines 10 to 9
if records.x_answer:
raise UserError("Survey alrady done, You can create new Lead/Opportunity and take new survey.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if records.x_answer:
raise UserError("Survey alrady done, You can create new Lead/Opportunity and take new survey.")
if records.x_answer:
raise UserError("Survey alrady done, You can create new Lead/Opportunity and take new survey.")

We can hide the button depending on the x_answer.

Comment on lines 12 to 11
if not records.x_survey:
raise UserError("Survey not selected.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

records.write({'x_answer': user_input.id})
action = {
'type': 'ir.actions.act_url',
'name': "Survey",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'name': "Survey",
'name': 'Survey',

@@ -0,0 +1,28 @@
<?xml version='1.0' encoding='UTF-8'?>
<odoo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<odoo>
<odoo noupdate="1">

<field name="url">/red-revolution-tomato-seeds</field>
<field name="view_id" ref="red_revolution_tomato_seeds"/>
<field name="is_published" eval="True"/>
<field name="is_in_menu" eval="False"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="is_in_menu" eval="False"/>

Compute?

</function>

<function name="write" model="ir.ui.view">
<value model="ir.ui.view" eval="obj().env['website'].with_context(website_id=obj().env.ref('website.default_website').id).viewref('website.homepage').id"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value model="ir.ui.view" eval="obj().env['website'].with_context(website_id=obj().env.ref('website.default_website').id).viewref('website.homepage').id"/>
<value model="ir.ui.view" eval="obj().env['website'].with_context(website_id=ref('website.default_website')).viewref('website.homepage').id"/>

?

</function>

<function name="write" model="ir.ui.view">
<value model="ir.ui.view" eval="obj().env['website'].with_context(website_id=obj().env.ref('website.default_website').id).viewref('website.contactus').id"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate image

@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch 4 times, most recently from c499a7c to 7160048 Compare February 21, 2024 06:36
@dhrs-odoo
Copy link
Contributor

Hello @paso-odoo Sir
Thanks for your Suggestions
I have implemented them
Thank You 😇

Copy link
Contributor

@paso-odoo paso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhrs-odoo

Thanks for working on this PR.
Here are some technical remarks from my side.

Cheers!

{
'name': 'Agricultural Retail',
'version': '1.0',
'category': 'Manufacturing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'category': 'Manufacturing',
'category': ''Retail'',

<?xml version='1.0' encoding='UTF-8'?>
<odoo>
<record id="action_lead_survey_start" model="ir.actions.server">
<field name="name">lead survey start</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="name">lead survey start</field>
<field name="name">Lead Survey Start</field>

<field name="model_id" ref="crm.model_crm_lead"/>
<field name="field_description">Answer</field>
<field name="relation">survey.user_input</field>
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</record>
</record>

<field name="model_id" ref="account.model_account_move_line"/>
<field name="field_description">Product Story</field>
<field name="related">product_id.x_binary_field_product_template</field>
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

<ul style="margin-bottom: 0px;">
<li>
Create RFQ for product "<font style="color: rgb(57, 132, 198);"><strong>Onion Seeds</strong></font>" for vendor "<span style="color: rgb(57, 132, 198); font-size: 0.9625rem;"><strong>Gloster Organics</strong></span>"
<span style="color: rgb(17, 24, 39); font-size: 0.9625rem;">"</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span style="color: rgb(17, 24, 39); font-size: 0.9625rem;">"</span>

<value model="stock.lot" eval="{'lot_id': ref('stock_lot_2'), 'lot_name': obj().env.ref('agriculture.stock_lot_2').name}"/>
</function>
<function name="button_validate" model="stock.picking">
<value model="stock.picking" eval="obj().env.ref('agriculture.purchase_order_1').group_id.stock_move_ids.picking_id.ids"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use picking_ids directly from purchase_order.

<record id="res_partner_10" model="res.partner">
<field name="name">Shailendra Rathod(SRA)</field>
<field name="email">sra@example.com</field>
<field name="phone">9876543210</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use fictive phone number

agriculture/demo/sale_order.xml Show resolved Hide resolved
<field name="name">LOT0001</field>
<field name="product_id" ref="product_product_12"/>
<field name="location_id" ref="stock.stock_location_stock"/>
<field name="product_expiry_reminded" eval="True"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="product_expiry_reminded" eval="True"/>

agriculture/demo/website_page.xml Show resolved Hide resolved
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch from 7160048 to cf31b9a Compare February 26, 2024 07:11
vrpa-odoo and others added 15 commits February 26, 2024 18:19
Tailored setup for agricultural retail businesses engaged in B2B and B2C sales
of farming products. Point of Sale (POS) stores & website offer categorised
items such as seeds, pesticides, plant nutrition, and farming equipment.

task- 3460550
Tailored setup for agricultural retail businesses engaged in B2B and B2C sales
of farming products. Point of Sale (POS) stores & website offer categorised
items such as seeds, pesticides, plant nutrition, and farming equipment.

task- 3460550
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch from cf31b9a to 03a26a6 Compare February 26, 2024 12:50
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch from 03a26a6 to 59c9d2c Compare February 26, 2024 13:15
@dhrs-odoo dhrs-odoo force-pushed the master-industry-agriculture-vrpa branch from 57f17b0 to 97208bc Compare February 27, 2024 06:24
@dhrs-odoo
Copy link
Contributor

Hello @paso-odoo
Given changes has been implemented
Thank You and Have a great day ahead 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for review and integration
Projects
None yet
8 participants