Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sales: fixed a loyalty card specificity #9225

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 6, 2024

implemented a necessary fix, as requested here: #9041

only line 88 was adjusted to adhere to the suggested fix (found in the link above)

This change should be forward ported

@ksc-odoo ksc-odoo added the 2 label May 6, 2024
@ksc-odoo ksc-odoo self-assigned this May 6, 2024
@ksc-odoo ksc-odoo requested a review from larm-odoo May 6, 2024 22:41
@robodoo
Copy link
Collaborator

robodoo commented May 6, 2024

@C3POdoo C3POdoo requested a review from a team May 6, 2024 22:41
@ksc-odoo ksc-odoo removed the request for review from a team May 6, 2024 22:42
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented May 6, 2024

hey @larm-odoo this super small adjustment is ready for a quick peer review from you whenever you get a chance (just one line - line 88/89) Thanks! 👍

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo - approving now! I just had one comment, lol - feels silly to leave one comment for one line change =D .

@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented May 7, 2024

Thanks for the quick review, @larm-odoo -- Looks like this one is ready for a Final Review, @StraubCreative 👍

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ksc-odoo
..
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants