[IMP] CRM: rewrite gamification config section #9061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StraubCreative This is ready for review. Thanks! |
|
@jero-odoo Conflict on #9040, addressing first before we can merge here... |
StraubCreative
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Looks good @jero-odoo
I did catch a rendering issue on the bulleted list, on line 105. Will push up a fix momentarily.
Again, waiting on merge here until the FWPs from the previous PR are merged in first.
Thanks for the quick fix!
StraubCreative
force-pushed
the
17.0-crm-gamification-config-jero
branch
from
633bad8
to
6abbd27
Compare
StraubCreative
force-pushed
the
17.0-crm-gamification-config-jero
branch
from
6abbd27
to
205f785
Compare
This was referenced May 2, 2024
jero-odoo
added a commit
that referenced
this pull request
May 3, 2024
closes #9061 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing changes from this task: https://www.odoo.com/mail/view?model=project.task&res_id=3896512&access_token=41050eb3-596d-47cc-832b-c8d047165a39
Editing config section (regarding module installation), updating two screenshots.