New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] finanace: avatax api integration rewrite #8997
Conversation
41f6de6
to
fe33ce6
Compare
fe33ce6
to
9c82e74
Compare
9c82e74
to
1138226
Compare
When each of you has a moment, can you review the Avatax rewrite? Both of you were involved in the Avatax script edit for Jose's eLearning video, so I decided to include you on this review. I am creating a separate doc for the Avalara Portal and Tax Calculation process. Thanks for your time with this. Please make comments. 👍 Tim |
Hi @tiku-odoo, thank you. I'll leave this one as I don't know the subject well enough. You can tag localization review once you need our review on a doc guideline pov. |
1138226
to
f4ad233
Compare
This doc is ready for your review when you have a moment. Thanks, |
@odoo/localizations-doc-review Here is the revised AvaTax integration doc for your review when you have a moment. Thanks! Tim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tiku-odoo !
I just wanted to drop a quick note to say fantastic work on putting together such clear and concise instructions for configuring all these different components. Your instructions were spot-on and worked perfectly during my runbot testing. It's evident that you put a lot of care into your testing and research, and I really appreciate the effort you've put into gathering and documenting all this information so quickly!
I did have a few minor suggestions for places where a bit more detail could be helpful for those who might not be familiar with every aspect of the AvaTax setup. And I also have a couple of optional rewording suggestions, just to consider.
Overall, though, I think you've done an incredible job with this document, and I'm excited to see it move forward to the next stage of review! Keep up the great work!
fc3b77c
to
06484eb
Compare
This doc is ready for your review when you have a moment. Thanks! Tim |
This doc is ready for your review when you have a moment. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo, this is an awesome PR and a huge content-add to documentation! Overall I dont have many changes, just a small handful of suggestions and corrections, please see below. I think it would be best for @ksc-odoo to do a full content review after this as well, just to be thorough.
Great work on this @tiku-odoo, looking forward to seeing this one out in the wild 💪
06484eb
to
ceaaf6b
Compare
This doc is ready for your review when you have a moment. Thanks, |
@odoo/localizations-doc-review This PR is ready for your review when you have a moment. Thanks 👍 Tim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo great one, thank you!
Let me know if my comments are clear. I noticed a conflict too in the checks.
Same as for the other PR I imagine once forward ported you will adapt the screenshots to newer versions.
ceaaf6b
to
adc4cae
Compare
adc4cae
to
2b13950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiku-odoo -- just finished my Final Review on this PR. Nice job! Very detailed and in-depth. I did leave a decent amount of comments, but they are all very minor/easy to deal with -- so I am approving now. Once you implement all the necessary changes, feel free to tag this for Tech Review. Thanks! 👍
2b13950
to
5450690
Compare
This doc has been reviewed by KC. You've already reviewed it, but I thought you might want to take another look to merge. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo, thanks for tagging me for one more review. This PR looks great to me! I flagged a couple quick fixes, please see below. Other than these I think this PR is good to go, so approving and delegating merge to you. Thanks for your hard work on this, and all the reviewers as well! 🚀
.....
@robodoo delegate=tiku-odoo
5450690
to
9b83359
Compare
@robodoo r+ |
closes #8997 Signed-off-by: Timothy Kukulka (tiku) <tiku@odoo.com>
Task: https://www.odoo.com/web#id=3601566&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form