Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] inventory: udpate shipments & deliveries doc #8850

Closed
wants to merge 1 commit into from
Closed

[IMP] inventory: udpate shipments & deliveries doc #8850

wants to merge 1 commit into from

Conversation

brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Apr 18, 2024 •
edited

This PR is an [IMP] to the shipments_deliveries doc in Odoo's Inventory documentation, specific to 17.0.

Here's what I did:

  • Rewrote some sections of the doc
  • Cleaned up other sections of the doc for specificity/new language and writing guidelines
  • Fixed outdated/incorrect doc links

Project Task Link

@robodoo
Copy link
Collaborator

robodoo commented Apr 18, 2024

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team April 18, 2024 18:58
@brse-odoo brse-odoo self-assigned this Apr 18, 2024
@brse-odoo
Copy link
Contributor Author

Hi @odoo/inventory-doc-review, this PR is ready for review when one of you has a chance. Thanks!

@brse-odoo
Copy link
Contributor Author

Hi @odoo/inventory-doc-review, this PR is ready for review when one of you has a chance. Thanks!

Hi @odoo/inventory-doc-review, this PR is ready for review, thank you!

Felicious
Felicious approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the rewrite of this doc, @brse-odoo! I had some very minor suggestions for you the consider 😄

...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-shipments-delivery-doc-brse branch from fad06dc to 2c1df56 Compare April 24, 2024 13:56
@brse-odoo
Copy link
Contributor Author

Alright @odoo/us-doc-review, this PR is ready for final content review, thank you in advance!

@brse-odoo brse-odoo requested a review from a team April 24, 2024 14:10
ksc-odoo
ksc-odoo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brse-odoo -- just finished my Final Review. Looks great! Just a small handful of minor suggestions that require your attention. approving now though. so, once those necessary modifications are made -- feel free to tag this for Tech Review

...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Outdated Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Show resolved Hide resolved
...ons/inventory_and_mrp/inventory/shipping_receiving/daily_operations/shipments_deliveries.rst Show resolved Hide resolved
@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-shipments-delivery-doc-brse branch from 2c1df56 to 8f28216 Compare April 24, 2024 17:28
@brse-odoo
Copy link
Contributor Author

Hi @samueljlieber, this PR is ready for your final lookover, thank you!

@brse-odoo brse-odoo requested a review from a team April 24, 2024 17:38
samueljlieber
samueljlieber approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @brse-odoo! Nice job 👍
...
@robodoo r+

@robodoo robodoo closed this in 3973c40 Apr 24, 2024
@fw-bot fw-bot mentioned this pull request Apr 24, 2024
Closed
This was referenced Apr 24, 2024
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Apr 28, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented Apr 29, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Assignees

@brse-odoo brse-odoo

Labels
3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@brse-odoo @robodoo @fw-bot @Felicious @samueljlieber @ksc-odoo @StraubCreative