Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] inventory: update 3 step delivery doc #8837

Closed
wants to merge 1 commit into from

Conversation

brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Apr 18, 2024

This PR is an [IMP] to the delivery_three_steps doc in Odoo's Inventory documentation, specific to 17.0.

Here's what I did:

  • Retooled some of the instructions/flow for 17.2 update that affected all multi-step routes
  • Replaced all screenshots for 17.2 UI, removed some screenshots no longer relevant

Note: This PR was only to update small instructions and replace screenshots. A second, targeted PR for a more robust rewrite will follow once this is merged.

Project Task Link

@robodoo
Copy link
Collaborator

robodoo commented Apr 18, 2024

@brse-odoo brse-odoo self-assigned this Apr 18, 2024
@C3POdoo C3POdoo requested a review from a team April 18, 2024 13:55
@brse-odoo
Copy link
Contributor Author

Hi @odoo/inventory-doc-review, this PR is ready for review when one of you has a chance. All that needs to be reviewed are the few lines that were changed, and the replaced screenshots. Thank you!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @brse-odoo ! I just had super minor suggestions for you to implement as you see fit. 😄

@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-delivery-3-steps-brse branch from cdcbb76 to 8279ea5 Compare April 22, 2024 13:26
@brse-odoo
Copy link
Contributor Author

Hi @odoo/us-doc-review, this PR is ready for final content review. Thank you!

@brse-odoo brse-odoo requested a review from a team April 22, 2024 15:43
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo

I like the revisions you made in the language and on a few screenshots.

For a few screenshot changes though, I'd suggest either reverting back to the former screenshot or retaking to cover more of the UI. I wrote my logic as to why I think this on the comments.

After reviewing/revising, please tag SALI for merge, thanks!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another item, see below please @brse-odoo

@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-delivery-3-steps-brse branch from 8279ea5 to 0b073aa Compare April 22, 2024 19:30
@brse-odoo
Copy link
Contributor Author

Hi @brse-odoo

I like the revisions you made in the language and on a few screenshots.

For a few screenshot changes though, I'd suggest either reverting back to the former screenshot or retaking to cover more of the UI. I wrote my logic as to why I think this on the comments.

After reviewing/revising, please tag SALI for merge, thanks!

Hi @samueljlieber, this PR has passed us-doc-review and is ready for your final lookover before merge, thank you!

@brse-odoo brse-odoo requested a review from a team April 22, 2024 19:35
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo, the changes in your PR looks good to me 👍 Nice work, thank you!
..
@robodoo r+

@fw-bot
Copy link
Collaborator

fw-bot commented Apr 27, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

9 similar comments
@fw-bot
Copy link
Collaborator

fw-bot commented Apr 28, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Apr 29, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Apr 30, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 1, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 2, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 3, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 5, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 13, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 29, 2024

@brse-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants