-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Manufacturing: Subcontracting overview #8723
Conversation
Hey @brse-odoo and @Felicious, This doc is ready for review. Please review PR #8701 first though, as that PR must be merged before this one. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hojo-odoo, this is a nice place to start if I wanted to learn about subcontracting! I left a bunch of optional comments, feel free to ignore them. I'm approving this doc because it's Friday, but here are some things to consider for an improvement doc down the line.
This page in general doesn't have specific information (which is not your fault), and since it serves more as a link to more specific subcontracting workflows, have you considered this page to be a toc file, and the other subcontracting docs sit in a subdirectory? ex: removal strategies overview. This is just an idea! Let me know offline if there's anything I can clarify for you!
Anyways, happy friday!
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
dc17e66
to
76a8373
Compare
Hey @ksc-odoo, This doc is ready for final review. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hojo-odoo -- just finished my Final Review. Great work on this Subcontracting overview to introduce the concept/functionality. Approving now, since there is only a handful of minor suggestions/adjustments that require your attention. Once you think it's good to go, tag ZST for Tech Review. Thanks! 👍
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/workflows/subcontracting.rst
Show resolved
Hide resolved
76a8373
to
2c28882
Compare
Hey @StraubCreative, This doc is ready for tech review. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hojo-odoo, awesome job on this PR. Your improvements to subcontracting.rst
look really great, kudos for removing 12 images 👏.
Since this PR is improving a file rather than adding one, please update the commit message tag to [IMP], using git commit --amend
.
Other than that, everything looks good to me! Nice job :) Approving and delegating merge to you at your discretion.
...
@robodoo delegate=hojo-odoo
2c28882
to
adfd632
Compare
@robodoo r+ |
closes #8723 Signed-off-by: John Holton (hojo) <hojo@odoo.com>
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
4 similar comments
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
This PR adds a new doc providing an overview of subcontracting in Odoo. Please review PR #8701 before this one, as that PR needs to be merged first.
NOTE: One of the checks for this PR is currently failing, this will be resolved once PRs #8536 and #8701 are live.