Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #137

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

alireza-rafeezadeh
Copy link

Updated dependencies
Changed jacoco gradle plugin dependency due to its problem with newer versions of gradle
arturdm/jacoco-android-gradle-plugin#72
https://plugins.gradle.org/plugin/com.hiya.jacoco-android

@odaridavid odaridavid self-requested a review June 15, 2021 08:17
Copy link
Owner

@odaridavid odaridavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alireza-rafeezadeh ,left a comment before I go ahead and merge this

}
dependencies {
classpath 'com.android.tools.build:gradle:3.5.2'
classpath 'com.android.tools.build:gradle:4.2.1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this gradle build tool plugin the android build tools sdk will also have to be updated to 30.0.2 for the build to pass ,modify its references in travis and the build.gradle.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odaridavid Alright I will fix it 👍

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #137 (e6fe369) into develop (641213f) will decrease coverage by 8.54%.
The diff coverage is n/a.

❗ Current head e6fe369 differs from pull request most recent head 6c1b0e1. Consider uploading reports for the commit 6c1b0e1 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #137      +/-   ##
=============================================
- Coverage      67.83%   59.28%   -8.55%     
- Complexity         0      163     +163     
=============================================
  Files             43       44       +1     
  Lines            628      646      +18     
  Branches         110      119       +9     
=============================================
- Hits             426      383      -43     
- Misses           134      175      +41     
- Partials          68       88      +20     
Impacted Files Coverage Δ
...tlin/com/k0d4black/theforce/TheForceApplication.kt 0.00% <0.00%> (-100.00%) ⬇️
...k0d4black/theforce/mappers/PresentationToDomain.kt 0.00% <0.00%> (-75.00%) ⬇️
...otlin/com/k0d4black/theforce/commons/Converters.kt 50.00% <0.00%> (-50.00%) ⬇️
...k0d4black/theforce/mappers/DomainToPresentation.kt 50.00% <0.00%> (-50.00%) ⬇️
.../com/k0d4black/theforce/viewmodel/BaseViewModel.kt 66.66% <0.00%> (-33.34%) ⬇️
.../k0d4black/theforce/viewmodel/FavoriteViewModel.kt 60.00% <0.00%> (-28.24%) ⬇️
...com/k0d4black/theforce/commons/ExceptionHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
.../theforce/viewmodel/DashboardFavoritesViewModel.kt 57.14% <0.00%> (-21.12%) ⬇️
...ack/theforce/viewmodel/CharacterDetailViewModel.kt 58.69% <0.00%> (-20.38%) ⬇️
...ack/theforce/viewmodel/DashboardSearchViewModel.kt 78.57% <0.00%> (-8.93%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641213f...6c1b0e1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants