REF: Refactor tests

[cortadocodes]

Summary

• Simplify BaseTestCase path attribute
• Use os.path.join in tests
• Remove simple single-use variables from tests

In tests.test_children:

• Allow python object input in Twine instantiation, allowing test cases to be brought directly in to tests
• Bring test cases directly in to tests, allowing the entire test to be seen in one go in one test method (rather than having to look at two files to see what is being tested), and avoiding the need for parsing from JSON to python object in the test suite
• Shorten strings in test cases so they span fewer lines
• I've done this only to this module as I thought there might be a reason that I've missed to keep the test cases as JSON files or to not allow python objects to be used as the source in Twine instantiation (I didn't want to change further test files without checking first!)

[codecov]

Codecov Report

Merging #39 into release/0.0.14 will decrease coverage by 0.36%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release/0.0.14      #39      +/-   ##
==================================================
- Coverage           86.20%   85.83%   -0.37%     
==================================================
  Files                   7        7              
  Lines                 232      233       +1     
==================================================
  Hits                  200      200              
- Misses                 32       33       +1     

Impacted Files	Coverage Δ
twined/twine.py	78.57% <100.00%> (-0.52%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82376eb...31e99c2. Read the comment docs.

[thclark]

I'm really happy with the refactor so far, thank you. Nothing crazy but it does make things a lot tidier.

On the file deletion, I've made a note on the concept of deserialisation, which it'd be important to understand. In general, I think the most straightforward thing would be to take the test fixtures out of files and put them in """{...}""" strings rather than converting to objects.

One thing I've realised I'm doing is that I'm copying/pasting the valid_*.json twines in the test cases as bases for building my own twines. They probably would be better off as examples in the documentation or elsewhere though, so I'm not willing to cling on to the file structure for that reason.

[thclark]

Well simplified path. The reason I used abspath and str sprang from refactoring twined out of the old Octue SDK where the CLI required absolute string paths. Assuming tests still pass, this is fine now.

I prefer to keep the setUp() pattern in general, because that sets path on the instance, not on the class. Any subclasses can therefore modify self.path without potential-weirdness affecting other tests running in parallel.

[cortadocodes]

As far as I'm aware, __file__ is an absolute path already and os.path.join always creates a string - let me know if this isn't the case!

Good point, I'll put it back in setUp 👍